Unify usage of logging/assert macros in base/

base/task/cancelable_task_tracker_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/task/cancelable_task_tracker.h"
 
 #include <cstddef>
 #include <deque>
 
 #include "base/bind.h"
@@ skipping 328 matching lines @@
 class CancelableTaskTrackerDeathTest : public CancelableTaskTrackerTest {
  protected:
   CancelableTaskTrackerDeathTest() {
     // The default style "fast" does not support multi-threaded tests.
     ::testing::FLAGS_gtest_death_test_style = "threadsafe";
   }
 };
 
 // Duplicated from base/threading/thread_checker.h so that we can be
 // good citizens there and undef the macro.
-#if !defined(NDEBUG) || defined(DCHECK_ALWAYS_ON)
+#if DCHECK_IS_ON()
 #define ENABLE_THREAD_CHECKER 1

[danakj, 2016/07/19 20:17:01]

Do we need this separate #define, or just use DCHECK_IS_ON?

[gab, 2016/07/20 02:43:58]

Done.

 #else
 #define ENABLE_THREAD_CHECKER 0
 #endif
 
 // Runs |fn| with |task_tracker|, expecting it to crash in debug mode.
 void MaybeRunDeadlyTaskTrackerMemberFunction(
     CancelableTaskTracker* task_tracker,
     const Callback<void(CancelableTaskTracker*)>& fn) {
 // CancelableTask uses DCHECKs with its ThreadChecker (itself only
 // enabled in debug mode).
@@ skipping 54 matching lines @@
 
   bad_thread.task_runner()->PostTask(
       FROM_HERE,
       Bind(&MaybeRunDeadlyTaskTrackerMemberFunction, Unretained(&task_tracker_),
            Bind(&CancelableTaskTracker::TryCancelAll)));
 
   test_task_runner->RunUntilIdle();
 }
 
 }  // namespace base