base/threading/non_thread_safe.h - Issue 2163023002: Unify usage of logging/assert macros in base/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/threading/non_thread_safe.h

Issue 2163023002: Unify usage of logging/assert macros in base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/threading/non_thread_safe.h

diff --git a/base/threading/non_thread_safe.h b/base/threading/non_thread_safe.h

index d41c08608c96a12d17c7a4d0da40d52607f81854..46d85e40162d3152efeb451f30b0fdaaa3d47736 100644

--- a/base/threading/non_thread_safe.h

+++ b/base/threading/non_thread_safe.h

@@ -10,9 +10,10 @@

// There is a specific macro to do it: NON_EXPORTED_BASE(), defined in

// compiler_specific.h

#include "base/compiler_specific.h"

+#include "base/logging.h"

// See comment at top of thread_checker.h

-#if (!defined(NDEBUG) || defined(DCHECK_ALWAYS_ON))

+#if DCHECK_IS_ON()

#define ENABLE_NON_THREAD_SAFE 1

danakj 2016/07/19 20:17:01 Same question, why not just DCHECK_IS_ON() instead

gab 2016/07/20 02:43:58 Done.

#else

#define ENABLE_NON_THREAD_SAFE 0