base/task_scheduler/scheduler_worker_pool_impl_unittest.cc - Issue 2163023002: Unify usage of logging/assert macros in base/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/task_scheduler/scheduler_worker_pool_impl_unittest.cc

Issue 2163023002: Unify usage of logging/assert macros in base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix base/android/build_info.cc compile Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/task_scheduler/scheduler_worker_pool_impl_unittest.cc

diff --git a/base/task_scheduler/scheduler_worker_pool_impl_unittest.cc b/base/task_scheduler/scheduler_worker_pool_impl_unittest.cc

index 7ae83ca95f9ff8fb48a0d322513ea7cb5aa8e341..4d560f3b57394fddaf575407ba3c17a660010d72 100644

--- a/base/task_scheduler/scheduler_worker_pool_impl_unittest.cc

+++ b/base/task_scheduler/scheduler_worker_pool_impl_unittest.cc

@@ -352,9 +352,6 @@ void ExpectIORestriction(IORestriction io_restriction, WaitableEvent* event) {

if (io_restriction == IORestriction::ALLOWED) {

ThreadRestrictions::AssertIOAllowed();

} else {

- static_assert(

- ENABLE_THREAD_RESTRICTIONS == DCHECK_IS_ON(),

- "ENABLE_THREAD_RESTRICTIONS and DCHECK_IS_ON() have diverged.");

EXPECT_DCHECK_DEATH({ ThreadRestrictions::AssertIOAllowed(); }, "");

}