Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2161493002: [DevTools] Pass client initiating DevToolsAgentHost::inspectElement. (Closed)

Created:
4 years, 5 months ago by dgozman
Modified:
4 years, 5 months ago
Reviewers:
Tom Sepez, pfeldman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, caseq+blink_chromium.org, jam, lushnikov+blink_chromium.org, blink-reviews-api_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, darin-cc_chromium.org, devtools-reviews_chromium.org, blink-reviews, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, kinuko+watch, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Pass client initiating DevToolsAgentHost::inspectElement. BUG=590878 Committed: https://crrev.com/9e2a3f0f53e1d90938c811bb90838d38e9fa07c6 Cr-Commit-Position: refs/heads/master@{#406104}

Patch Set 1 #

Total comments: 4

Patch Set 2 : fixed ShellDevToolsFrontend #

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -24 lines) Patch
M chrome/browser/devtools/devtools_window.cc View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/devtools/devtools_agent_host_impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/devtools/devtools_agent_host_impl.cc View 2 chunks +10 lines, -1 line 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/common/devtools_messages.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/public/browser/devtools_agent_host.h View 1 chunk +4 lines, -2 lines 0 comments Download
M content/renderer/devtools/devtools_agent.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/devtools/devtools_agent.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/shell/browser/shell_devtools_frontend.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/browser/shell_devtools_frontend.cc View 1 3 chunks +14 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebDevToolsAgent.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (9 generated)
dgozman
Could you please take a look? Pavel - at the whole patch. Tom - at ...
4 years, 5 months ago (2016-07-18 01:46:52 UTC) #2
Tom Sepez
https://codereview.chromium.org/2161493002/diff/1/chrome/browser/devtools/devtools_window.cc File chrome/browser/devtools/devtools_window.cc (right): https://codereview.chromium.org/2161493002/diff/1/chrome/browser/devtools/devtools_window.cc#newcode560 chrome/browser/devtools/devtools_window.cc:560: if (should_measure_time && window) nit: combine with above to ...
4 years, 5 months ago (2016-07-18 16:15:49 UTC) #3
dgozman
https://codereview.chromium.org/2161493002/diff/1/content/common/devtools_messages.h File content/common/devtools_messages.h (right): https://codereview.chromium.org/2161493002/diff/1/content/common/devtools_messages.h#newcode104 content/common/devtools_messages.h:104: int /* session_id */, On 2016/07/18 16:15:49, Tom Sepez ...
4 years, 5 months ago (2016-07-18 16:23:49 UTC) #4
Tom Sepez
> DevToolsAgentHostImpl generates one. This message is browser->renderer only. We > also use the same ...
4 years, 5 months ago (2016-07-18 16:30:26 UTC) #5
pfeldman
lgtm
4 years, 5 months ago (2016-07-18 18:26:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2161493002/1
4 years, 5 months ago (2016-07-18 18:52:47 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/97869)
4 years, 5 months ago (2016-07-18 19:09:57 UTC) #10
dgozman
https://codereview.chromium.org/2161493002/diff/1/chrome/browser/devtools/devtools_window.cc File chrome/browser/devtools/devtools_window.cc (right): https://codereview.chromium.org/2161493002/diff/1/chrome/browser/devtools/devtools_window.cc#newcode560 chrome/browser/devtools/devtools_window.cc:560: if (should_measure_time && window) On 2016/07/18 16:15:49, Tom Sepez ...
4 years, 5 months ago (2016-07-18 19:55:59 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2161493002/40001
4 years, 5 months ago (2016-07-18 19:57:07 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-18 21:37:09 UTC) #18
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 21:37:20 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 21:39:16 UTC) #21
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/9e2a3f0f53e1d90938c811bb90838d38e9fa07c6
Cr-Commit-Position: refs/heads/master@{#406104}

Powered by Google App Engine
This is Rietveld 408576698