Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Unified Diff: content/browser/devtools/render_frame_devtools_agent_host.cc

Issue 2161493002: [DevTools] Pass client initiating DevToolsAgentHost::inspectElement. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/devtools/devtools_agent_host_impl.cc ('k') | content/common/devtools_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/render_frame_devtools_agent_host.cc
diff --git a/content/browser/devtools/render_frame_devtools_agent_host.cc b/content/browser/devtools/render_frame_devtools_agent_host.cc
index 7be35fe4cdcdd222203268e74598bdfe30535ef5..48dd0d4ae92010463e1404b1d9c7d0e6c90f940f 100644
--- a/content/browser/devtools/render_frame_devtools_agent_host.cc
+++ b/content/browser/devtools/render_frame_devtools_agent_host.cc
@@ -104,7 +104,7 @@ class RenderFrameDevToolsAgentHost::FrameHostHolder {
int call_id,
const std::string& method,
const std::string& message);
- void InspectElement(int x, int y);
+ void InspectElement(int session_id, int x, int y);
void ProcessChunkedMessageFromAgent(const DevToolsMessageChunk& chunk);
void Suspend();
void Resume();
@@ -211,10 +211,10 @@ void RenderFrameDevToolsAgentHost::FrameHostHolder::DispatchProtocolMessage(
}
void RenderFrameDevToolsAgentHost::FrameHostHolder::InspectElement(
- int x, int y) {
+ int session_id, int x, int y) {
DCHECK(attached_);
host_->Send(new DevToolsAgentMsg_InspectElement(
- host_->GetRoutingID(), x, y));
+ host_->GetRoutingID(), session_id, x, y));
}
void
@@ -510,9 +510,9 @@ bool RenderFrameDevToolsAgentHost::DispatchProtocolMessage(
void RenderFrameDevToolsAgentHost::InspectElement(int x, int y) {
if (current_)
- current_->InspectElement(x, y);
+ current_->InspectElement(session_id(), x, y);
if (pending_)
- pending_->InspectElement(x, y);
+ pending_->InspectElement(session_id(), x, y);
}
void RenderFrameDevToolsAgentHost::OnClientAttached() {
« no previous file with comments | « content/browser/devtools/devtools_agent_host_impl.cc ('k') | content/common/devtools_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698