Chromium Code Reviews Chromium Code Reviews
Issue 2161493002:
[DevTools] Pass client initiating DevToolsAgentHost::inspectElement. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 // Developer tools consist of the following parts: | 5 // Developer tools consist of the following parts: |
| 6 // | 6 // |
| 7 // DevToolsAgent lives in the renderer of an inspected page and provides access | 7 // DevToolsAgent lives in the renderer of an inspected page and provides access |
| 8 // to the pages resources, DOM, v8 etc. by means of IPC messages. | 8 // to the pages resources, DOM, v8 etc. by means of IPC messages. |
| 9 // | 9 // |
| 10 // DevToolsClient is a thin delegate that lives in the tools front-end | 10 // DevToolsClient is a thin delegate that lives in the tools front-end |
| (...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 93 IPC_MESSAGE_ROUTED0(DevToolsAgentMsg_Detach) | 93 IPC_MESSAGE_ROUTED0(DevToolsAgentMsg_Detach) |
| 94 | 94 |
| 95 // WebKit-level transport. | 95 // WebKit-level transport. |
| 96 IPC_MESSAGE_ROUTED4(DevToolsAgentMsg_DispatchOnInspectorBackend, | 96 IPC_MESSAGE_ROUTED4(DevToolsAgentMsg_DispatchOnInspectorBackend, |
| 97 int /* session_id */, | 97 int /* session_id */, |
| 98 int /* call_id */, | 98 int /* call_id */, |
| 99 std::string /* method */, | 99 std::string /* method */, |
| 100 std::string /* message */) | 100 std::string /* message */) |
| 101 | 101 |
| 102 // Inspect element with the given coordinates. | 102 // Inspect element with the given coordinates. |
| 103 IPC_MESSAGE_ROUTED2(DevToolsAgentMsg_InspectElement, | 103 IPC_MESSAGE_ROUTED3(DevToolsAgentMsg_InspectElement, |
| 104 int /* session_id */, | |
|
Tom Sepez
2016/07/18 16:15:49
Who generates session_id? Can we trust it? What
dgozman
2016/07/18 16:23:49
DevToolsAgentHostImpl generates one. This message
| |
| 104 int /* x */, | 105 int /* x */, |
| 105 int /* y */) | 106 int /* y */) |
| 106 | 107 |
| 107 // ACK for DevToolsAgentHostMsg_RequestNewWindow message. | 108 // ACK for DevToolsAgentHostMsg_RequestNewWindow message. |
| 108 IPC_MESSAGE_ROUTED1(DevToolsAgentMsg_RequestNewWindow_ACK, | 109 IPC_MESSAGE_ROUTED1(DevToolsAgentMsg_RequestNewWindow_ACK, |
| 109 bool /* success */) | 110 bool /* success */) |
| 110 | 111 |
| 111 //----------------------------------------------------------------------------- | 112 //----------------------------------------------------------------------------- |
| 112 // These are messages sent from renderer's DevToolsAgent to browser. | 113 // These are messages sent from renderer's DevToolsAgent to browser. |
| 113 | 114 |
| (...skipping 13 matching lines...) Expand all Loading... | |
| 127 IPC_MESSAGE_ROUTED1(DevToolsMsg_SetupDevToolsClient, | 128 IPC_MESSAGE_ROUTED1(DevToolsMsg_SetupDevToolsClient, |
| 128 std::string /* compatibility script */) | 129 std::string /* compatibility script */) |
| 129 | 130 |
| 130 | 131 |
| 131 //----------------------------------------------------------------------------- | 132 //----------------------------------------------------------------------------- |
| 132 // These are messages sent from the renderer to the browser. | 133 // These are messages sent from the renderer to the browser. |
| 133 | 134 |
| 134 // Transport from Inspector frontend to frontend host. | 135 // Transport from Inspector frontend to frontend host. |
| 135 IPC_MESSAGE_ROUTED1(DevToolsHostMsg_DispatchOnEmbedder, | 136 IPC_MESSAGE_ROUTED1(DevToolsHostMsg_DispatchOnEmbedder, |
| 136 std::string /* message */) | 137 std::string /* message */) |
| OLD | NEW |
