content/browser/devtools/devtools_agent_host_impl.h - Issue 2161493002: [DevTools] Pass client initiating DevToolsAgentHost::inspectElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/devtools_agent_host_impl.h

Issue 2161493002: [DevTools] Pass client initiating DevToolsAgentHost::inspectElement. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/devtools/devtools_agent_host_impl.h

diff --git a/content/browser/devtools/devtools_agent_host_impl.h b/content/browser/devtools/devtools_agent_host_impl.h

index ddd2917e4b57133908eb12c278c25b6c912389ca..fa966c4c658d7d0a6c77e7fffcb359c1f5c7393c 100644

--- a/content/browser/devtools/devtools_agent_host_impl.h

+++ b/content/browser/devtools/devtools_agent_host_impl.h

@@ -45,7 +45,7 @@ class CONTENT_EXPORT DevToolsAgentHostImpl : public DevToolsAgentHost,

const std::string& message) override;

bool IsAttached() override;

- void InspectElement(int x, int y) override;

+ void InspectElement(DevToolsAgentHostClient* client, int x, int y) override;

std::string GetId() override;

BrowserContext* GetBrowserContext() override;

WebContents* GetWebContents() override;

@@ -62,6 +62,7 @@ class CONTENT_EXPORT DevToolsAgentHostImpl : public DevToolsAgentHost,

~DevToolsAgentHostImpl() override;

virtual bool DispatchProtocolMessage(const std::string& message) = 0;

+ virtual void InspectElement(int x, int y);

void HostClosed();

void SendMessageToClient(int session_id, const std::string& message);

« no previous file with comments | « chrome/browser/devtools/devtools_window.cc ('k') | content/browser/devtools/devtools_agent_host_impl.cc » ('j') | no next file with comments »