Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2160483002: Make CSSStyleValue::toCSSValue() return a const CSSValue* (Closed)

Created:
4 years, 5 months ago by sashab
Modified:
4 years, 5 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@_make_cssvaluepair_take_const
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make CSSStyleValue::toCSSValue() return a const CSSValue* Make CSSStyleValue::toCSSValue() return a const CSSValue*, and update callsites to match (including updating Element::setInlineStyleProperty() to take a const CSSValue*). This is an entirely mechanical change that is more semantically correct and safe. BUG=526586 Committed: https://crrev.com/ae9bccd603ed3d867557a0ec4231bccf67640223 Cr-Commit-Position: refs/heads/master@{#406497}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -17 lines) Patch
M third_party/WebKit/Source/core/css/cssom/CSSStyleValue.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSTransformValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSTransformValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSUnsupportedStyleValue.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSUnsupportedStyleValue.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (9 generated)
sashab
4 years, 5 months ago (2016-07-18 01:41:12 UTC) #4
haraken
LGTM
4 years, 5 months ago (2016-07-18 01:53:41 UTC) #5
Bugs Nash
lgtm
4 years, 5 months ago (2016-07-18 02:05:26 UTC) #7
sashab
Eddy fyi :)
4 years, 5 months ago (2016-07-19 03:38:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160483002/1
4 years, 5 months ago (2016-07-20 02:48:39 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 04:50:27 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 04:50:31 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 04:53:32 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae9bccd603ed3d867557a0ec4231bccf67640223
Cr-Commit-Position: refs/heads/master@{#406497}

Powered by Google App Engine
This is Rietveld 408576698