Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2160483002: Make CSSStyleValue::toCSSValue() return a const CSSValue* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_make_cssvaluepair_take_const
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/Element.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
8 * (C) 2007 Eric Seidel (eric@webkit.org) 8 * (C) 2007 Eric Seidel (eric@webkit.org)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 3557 matching lines...) Expand 10 before | Expand all | Expand 10 after
3568 void Element::setInlineStyleProperty(CSSPropertyID propertyID, CSSValueID identi fier, bool important) 3568 void Element::setInlineStyleProperty(CSSPropertyID propertyID, CSSValueID identi fier, bool important)
3569 { 3569 {
3570 setInlineStyleProperty(propertyID, CSSPrimitiveValue::createIdentifier(ident ifier), important); 3570 setInlineStyleProperty(propertyID, CSSPrimitiveValue::createIdentifier(ident ifier), important);
3571 } 3571 }
3572 3572
3573 void Element::setInlineStyleProperty(CSSPropertyID propertyID, double value, CSS PrimitiveValue::UnitType unit, bool important) 3573 void Element::setInlineStyleProperty(CSSPropertyID propertyID, double value, CSS PrimitiveValue::UnitType unit, bool important)
3574 { 3574 {
3575 setInlineStyleProperty(propertyID, CSSPrimitiveValue::create(value, unit), i mportant); 3575 setInlineStyleProperty(propertyID, CSSPrimitiveValue::create(value, unit), i mportant);
3576 } 3576 }
3577 3577
3578 void Element::setInlineStyleProperty(CSSPropertyID propertyID, CSSValue* value, bool important) 3578 void Element::setInlineStyleProperty(CSSPropertyID propertyID, const CSSValue* v alue, bool important)
3579 { 3579 {
3580 DCHECK(isStyledElement()); 3580 DCHECK(isStyledElement());
3581 ensureMutableInlineStyle().setProperty(propertyID, value, important); 3581 ensureMutableInlineStyle().setProperty(propertyID, value, important);
3582 inlineStyleChanged(); 3582 inlineStyleChanged();
3583 } 3583 }
3584 3584
3585 bool Element::setInlineStyleProperty(CSSPropertyID propertyID, const String& val ue, bool important) 3585 bool Element::setInlineStyleProperty(CSSPropertyID propertyID, const String& val ue, bool important)
3586 { 3586 {
3587 DCHECK(isStyledElement()); 3587 DCHECK(isStyledElement());
3588 bool changes = ensureMutableInlineStyle().setProperty(propertyID, value, imp ortant, document().elementSheet().contents()); 3588 bool changes = ensureMutableInlineStyle().setProperty(propertyID, value, imp ortant, document().elementSheet().contents());
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
3745 3745
3746 DEFINE_TRACE_WRAPPERS(Element) 3746 DEFINE_TRACE_WRAPPERS(Element)
3747 { 3747 {
3748 if (hasRareData()) { 3748 if (hasRareData()) {
3749 visitor->traceWrappers(elementRareData()); 3749 visitor->traceWrappers(elementRareData());
3750 } 3750 }
3751 ContainerNode::traceWrappers(visitor); 3751 ContainerNode::traceWrappers(visitor);
3752 } 3752 }
3753 3753
3754 } // namespace blink 3754 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/Element.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698