third_party/WebKit/Source/core/css/cssom/CSSUnsupportedStyleValue.cpp - Issue 2160483002: Make CSSStyleValue::toCSSValue() return a const CSSValue*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSUnsupportedStyleValue.cpp

Issue 2160483002: Make CSSStyleValue::toCSSValue() return a const CSSValue* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_make_cssvaluepair_take_const

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/cssom/CSSUnsupportedStyleValue.h ('k') | third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/cssom/CSSUnsupportedStyleValue.cpp

diff --git a/third_party/WebKit/Source/core/css/cssom/CSSUnsupportedStyleValue.cpp b/third_party/WebKit/Source/core/css/cssom/CSSUnsupportedStyleValue.cpp

index 5ca9cb88a501d7007c61ef3d7412010dcba5b108..7dc753c748243f40c1a027c9735d15c987f6ac31 100644

--- a/third_party/WebKit/Source/core/css/cssom/CSSUnsupportedStyleValue.cpp

+++ b/third_party/WebKit/Source/core/css/cssom/CSSUnsupportedStyleValue.cpp

@@ -9,16 +9,15 @@

namespace blink {

-CSSValue* CSSUnsupportedStyleValue::toCSSValue() const

+const CSSValue* CSSUnsupportedStyleValue::toCSSValue() const

{

NOTREACHED();

return nullptr;

}

-CSSValue* CSSUnsupportedStyleValue::toCSSValueWithProperty(CSSPropertyID propertyID) const

+const CSSValue* CSSUnsupportedStyleValue::toCSSValueWithProperty(CSSPropertyID propertyID) const

{

- // TODO(sashab): Make CSSStyleValue return const CSSValue*s and remove this cast.

- return const_cast<CSSValue*>(CSSParser::parseSingleValue(propertyID, m_cssText, strictCSSParserContext()));

+ return CSSParser::parseSingleValue(propertyID, m_cssText, strictCSSParserContext());

}

} // namespace blink