Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2160373003: [DevTools] Make NetworkAgent.Initiator 0-based (Closed)

Created:
4 years, 5 months ago by kozy
Modified:
4 years, 5 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@make-message-0-based
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Make NetworkAgent.Initiator 0-based R=dgozman@chromium.org Committed: https://crrev.com/40f32e876f7611a8b9eee08a8a298027e8493942 Cr-Commit-Position: refs/heads/master@{#406489}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/network/network-initiator-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2163803002 Patch 1

Messages

Total messages: 7 (2 generated)
kozy
ptal
4 years, 5 months ago (2016-07-20 00:11:51 UTC) #1
dgozman
lgtm
4 years, 5 months ago (2016-07-20 01:02:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160373003/1
4 years, 5 months ago (2016-07-20 02:41:19 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 04:33:24 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 04:35:14 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/40f32e876f7611a8b9eee08a8a298027e8493942
Cr-Commit-Position: refs/heads/master@{#406489}

Powered by Google App Engine
This is Rietveld 408576698