Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2163803002: [DevTools] Make WebInspector.ConsoleMessage 0-based (Closed)

Created:
4 years, 5 months ago by kozy
Modified:
4 years, 5 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Make WebInspector.ConsoleMessage 0-based BUG=591496 R=dgozman@chromium.org Committed: https://crrev.com/6d1e7a0c7e9257bff65c15ff4c2161ea448f8751 Cr-Commit-Position: refs/heads/master@{#406469}

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -24 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/stacktraces/csp-inline-warning-contains-stacktrace-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/stacktraces/csp-setInterval-warning-contains-stacktrace-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/stacktraces/csp-setTimeout-warning-contains-stacktrace-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-log-in-xhtml-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-log-syntax-error-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
kozy
Dmitry, please take a look!
4 years, 5 months ago (2016-07-19 20:59:07 UTC) #1
dgozman
lgtm https://codereview.chromium.org/2163803002/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js File third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js (right): https://codereview.chromium.org/2163803002/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js#newcode526 third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js:526: typeof payload.lineNumber === "undefined" ? undefined : payload.lineNumber, ...
4 years, 5 months ago (2016-07-20 00:59:14 UTC) #4
kozy
thanks! all done! https://codereview.chromium.org/2163803002/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js File third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js (right): https://codereview.chromium.org/2163803002/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js#newcode526 third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js:526: typeof payload.lineNumber === "undefined" ? undefined ...
4 years, 5 months ago (2016-07-20 01:11:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163803002/40001
4 years, 5 months ago (2016-07-20 01:12:11 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 5 months ago (2016-07-20 02:34:19 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 02:34:21 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 02:36:44 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/6d1e7a0c7e9257bff65c15ff4c2161ea448f8751
Cr-Commit-Position: refs/heads/master@{#406469}

Powered by Google App Engine
This is Rietveld 408576698