third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp - Issue 2160373003: [DevTools] Make NetworkAgent.Initiator 0-based

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

Issue 2160373003: [DevTools] Make NetworkAgent.Initiator 0-based (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@make-message-0-based

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/network/network-initiator-expected.txt ('k') | third_party/WebKit/Source/core/inspector/browser_protocol.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

index 1856656ed0fb9f2696f0900ed29e97d12a7e229f..2f161f11bd4103de168f9a3e933f3a6a9005a69d 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

@@ -845,9 +845,9 @@ std::unique_ptr<protocol::Network::Initiator> InspectorNetworkAgent::buildInitia

.setType(protocol::Network::Initiator::TypeEnum::Parser).build();

initiatorObject->setUrl(urlWithoutFragment(document->url()).getString());

if (TextPosition::belowRangePosition() != initiatorInfo.position)

- initiatorObject->setLineNumber(initiatorInfo.position.m_line.oneBasedInt());

+ initiatorObject->setLineNumber(initiatorInfo.position.m_line.zeroBasedInt());

else

- initiatorObject->setLineNumber(document->scriptableDocumentParser()->lineNumber().oneBasedInt());

+ initiatorObject->setLineNumber(document->scriptableDocumentParser()->lineNumber().zeroBasedInt());

return initiatorObject;

}