third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js - Issue 2160373003: [DevTools] Make NetworkAgent.Initiator 0-based

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

Issue 2160373003: [DevTools] Make NetworkAgent.Initiator 0-based (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@make-message-0-based

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/browser_protocol.json ('k') | third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

index fe5f0dcdbef51a425447976b05a2fbcda403516e..ab7e7cf72d5092a0479bb124336805d11dbeac51 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

@@ -340,9 +340,9 @@ WebInspector.NetworkDataGridNode.prototype = {

cell.appendChild(createTextNode(WebInspector.UIString("Push / ")));

switch (initiator.type) {

case WebInspector.NetworkRequest.InitiatorType.Parser:

- cell.title = initiator.url + ":" + initiator.lineNumber;

+ cell.title = initiator.url + ":" + (initiator.lineNumber + 1);

var uiSourceCode = WebInspector.networkMapping.uiSourceCodeForURLForAnyTarget(initiator.url);

- cell.appendChild(WebInspector.linkifyResourceAsNode(initiator.url, initiator.lineNumber - 1, initiator.columnNumber - 1, undefined, undefined, uiSourceCode ? uiSourceCode.displayName() : undefined));

+ cell.appendChild(WebInspector.linkifyResourceAsNode(initiator.url, initiator.lineNumber, initiator.columnNumber, undefined, undefined, uiSourceCode ? uiSourceCode.displayName() : undefined));

this._appendSubtitle(cell, WebInspector.UIString("Parser"));

break;

@@ -356,7 +356,7 @@ WebInspector.NetworkDataGridNode.prototype = {

case WebInspector.NetworkRequest.InitiatorType.Script:

if (!this._linkifiedInitiatorAnchor) {

- this._linkifiedInitiatorAnchor = this._parentView.linkifier.linkifyScriptLocation(request.target(), initiator.scriptId, initiator.url, initiator.lineNumber - 1, initiator.columnNumber - 1);

+ this._linkifiedInitiatorAnchor = this._parentView.linkifier.linkifyScriptLocation(request.target(), initiator.scriptId, initiator.url, initiator.lineNumber, initiator.columnNumber);

this._linkifiedInitiatorAnchor.title = "";

}

cell.appendChild(this._linkifiedInitiatorAnchor);