Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2160173002: [MD History] Move the shared menu from history list to list container. (Closed)

Created:
4 years, 5 months ago by calamity
Modified:
4 years, 5 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@research
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD History] Move the shared menu from history list to list container. This CL moves the shared overflow menu in the history list up to the history list container so that it can be used by both the history list and the grouped history list. This refactor also prepares for shift selection in the history list. BUG=589363 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/456c3151c67045b6454d302490d1af26bad0905a Cr-Commit-Position: refs/heads/master@{#406788}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Messages

Total messages: 11 (4 generated)
calamity
4 years, 5 months ago (2016-07-19 06:49:34 UTC) #3
tsergeant
🆒 https://codereview.chromium.org/2160173002/diff/20001/chrome/browser/resources/md_history/history_list.js File chrome/browser/resources/md_history/history_list.js (right): https://codereview.chromium.org/2160173002/diff/20001/chrome/browser/resources/md_history/history_list.js#newcode29 chrome/browser/resources/md_history/history_list.js:29: 'infinite-list.scroll': 'notifyListScroll_', Rather than firing a new event, ...
4 years, 5 months ago (2016-07-19 07:12:48 UTC) #4
calamity
https://codereview.chromium.org/2160173002/diff/20001/chrome/browser/resources/md_history/history_list.js File chrome/browser/resources/md_history/history_list.js (right): https://codereview.chromium.org/2160173002/diff/20001/chrome/browser/resources/md_history/history_list.js#newcode29 chrome/browser/resources/md_history/history_list.js:29: 'infinite-list.scroll': 'notifyListScroll_', On 2016/07/19 07:12:47, tsergeant wrote: > Rather ...
4 years, 5 months ago (2016-07-20 05:24:38 UTC) #5
tsergeant
lgtm
4 years, 5 months ago (2016-07-20 07:42:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160173002/20001
4 years, 5 months ago (2016-07-21 05:25:21 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-21 06:35:09 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 06:38:03 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/456c3151c67045b6454d302490d1af26bad0905a
Cr-Commit-Position: refs/heads/master@{#406788}

Powered by Google App Engine
This is Rietveld 408576698