[MD History] Force history results to be processed in order.

[MD History] Force history results to be processed in order.

This CL fixes an issue where history results could be returned in
quick succession but the later result set would be processed first due
to the earlier result set being deferred to the next event loop. This
was causing problems with loading search URLs that loaded too quickly.

This has been fixed by using a single Promise to process all history
results rather than instantiating new ones for each result set.

BUG=630125
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/45eaf49a7cea5e2188ecacb01c0579d7035963ac
Cr-Commit-Position: refs/heads/master@{#407411}

[calamity, 2016-07-21 07:01:04]

Description was changed from

==========
[MD History] Force history results to be processed in order.

This CL fixes an issue where history results could be returned in
quick succession but the later result set would be processed first due
to the earlier result set being deferred to the next event loop. This
was causing problems with loading search URLs that loaded too quickly.

This has been fixed by using a single Promise to process all history
results rather than instantiating new ones for each result set.

BUG=630125
==========

to

==========
[MD History] Force history results to be processed in order.

This CL fixes an issue where history results could be returned in
quick succession but the later result set would be processed first due
to the earlier result set being deferred to the next event loop. This
was causing problems with loading search URLs that loaded too quickly.

This has been fixed by using a single Promise to process all history
results rather than instantiating new ones for each result set.

BUG=630125
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[calamity, 2016-07-21 07:04:11]

Patchset #1 (id:1) has been deleted

[calamity, 2016-07-21 07:04:32]

calamity@chromium.org changed reviewers:
+ tsergeant@chromium.org

[tsergeant, 2016-07-21 07:25:27]

lgtm % nit and rebase

https://codereview.chromium.org/2171693002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_history/history.js (right):

https://codereview.chromium.org/2171693002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/history.js:10: var upgradePromise = null;
Nit: /** @type {Promise} */

https://codereview.chromium.org/2171693002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/md_history/md_history_browsertest.js (right):

https://codereview.chromium.org/2171693002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_history/md_history_browsertest.js:135: return
waitForAppUpgrade().then(function() {
Somehow you ended up basing this patch against a version which still has the
.then() clause here. You'll probably get a patch failure unless you rebase.

[calamity, 2016-07-22 05:04:45]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 05:05:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 05:42:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 05:42:55]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[calamity, 2016-07-25 02:47:24]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 02:47:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 03:42:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 03:42:51]

Dry run: This issue passed the CQ dry run.

[calamity, 2016-07-25 03:43:31]

https://codereview.chromium.org/2171693002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_history/history.js (right):

https://codereview.chromium.org/2171693002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/history.js:10: var upgradePromise = null;
On 2016/07/21 07:25:27, tsergeant wrote:
> Nit: /** @type {Promise} */

Done.

https://codereview.chromium.org/2171693002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/md_history/md_history_browsertest.js (right):

https://codereview.chromium.org/2171693002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_history/md_history_browsertest.js:135: return
waitForAppUpgrade().then(function() {
On 2016/07/21 07:25:27, tsergeant wrote:
> Somehow you ended up basing this patch against a version which still has the
> .then() clause here. You'll probably get a patch failure unless you rebase.

Done.

[calamity, 2016-07-25 03:44:10]

The CQ bit was checked by calamity@chromium.org

[calamity, 2016-07-25 03:44:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org
Link to the patchset: https://codereview.chromium.org/2171693002/#ps60001
(title: "missed one")

[commit-bot: I haz the power, 2016-07-25 03:44:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 03:47:45]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-07-25 03:49:19]

Description was changed from

==========
[MD History] Force history results to be processed in order.

This CL fixes an issue where history results could be returned in
quick succession but the later result set would be processed first due
to the earlier result set being deferred to the next event loop. This
was causing problems with loading search URLs that loaded too quickly.

This has been fixed by using a single Promise to process all history
results rather than instantiating new ones for each result set.

BUG=630125
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Force history results to be processed in order.

This CL fixes an issue where history results could be returned in
quick succession but the later result set would be processed first due
to the earlier result set being deferred to the next event loop. This
was causing problems with loading search URLs that loaded too quickly.

This has been fixed by using a single Promise to process all history
results rather than instantiating new ones for each result set.

BUG=630125
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/45eaf49a7cea5e2188ecacb01c0579d7035963ac
Cr-Commit-Position: refs/heads/master@{#407411}
==========

[commit-bot: I haz the power, 2016-07-25 03:49:20]

Patchset 3 (id:??) landed as
https://crrev.com/45eaf49a7cea5e2188ecacb01c0579d7035963ac
Cr-Commit-Position: refs/heads/master@{#407411}