Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1158)

Unified Diff: chrome/test/data/webui/md_history/history_list_test.js

Issue 2160173002: [MD History] Move the shared menu from history list to list container. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@research
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/md_history/history_list_test.js
diff --git a/chrome/test/data/webui/md_history/history_list_test.js b/chrome/test/data/webui/md_history/history_list_test.js
index a5ad099162fe102478e5b0b0456526b94ca2767c..e1274db5547051c02fd5735c9891345cdc9501ec 100644
--- a/chrome/test/data/webui/md_history/history_list_test.js
+++ b/chrome/test/data/webui/md_history/history_list_test.js
@@ -174,8 +174,25 @@ cr.define('md_history.history_list_test', function() {
});
});
- element.$.sharedMenu.itemData = {domain: 'example.com'};
- MockInteractions.tap(element.$.menuMoreButton);
+ app.$['history'].$.sharedMenu.itemData = {domain: 'example.com'};
+ MockInteractions.tap(app.$['history'].$.menuMoreButton);
+ });
+
+ test('scrolling history list closes overflow menu', function() {
+ var sharedMenu = app.$.history.$.sharedMenu;
+ for (var i = 0; i < 10; i++)
+ app.historyResult(createHistoryInfo(), TEST_HISTORY_RESULTS);
+
+ return flush().then(function() {
+ items = Polymer.dom(element.root).querySelectorAll('history-item');
+
+ MockInteractions.tap(items[2].$['menu-button']);
+ assertTrue(sharedMenu.menuOpen);
+ element.$['infinite-list'].scrollTop = 100;
+ return flush();
+ }).then(function() {
+ assertFalse(sharedMenu.menuOpen);
+ });
});
test('changing search deselects items', function() {

Powered by Google App Engine
This is Rietveld 408576698