Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2172563002: [MD History] Use openForeignSession message to open foreign session tabs. (Closed)

Created:
4 years, 5 months ago by calamity
Modified:
4 years, 4 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, jlklein+watch-closure_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@move_menu_up
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD History] Use openForeignSession message to open foreign session tabs. This CL makes the synced tabs page use the same message as the old history page to open synced tabs. This also fixes an issue with the way the Open All Tabs button behaves which now opens all new tabs in separate windows. BUG=622215 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/63780b934269e5524d7ac0d93792001b3f69ff4b Cr-Commit-Position: refs/heads/master@{#408061}

Patch Set 1 #

Total comments: 15

Patch Set 2 : address comments, closure compile broken #

Patch Set 3 : "fix" closure compile #

Patch Set 4 : add closure cast #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -18 lines) Patch
M chrome/browser/resources/history/externs.js View 2 chunks +23 lines, -13 lines 0 comments Download
M chrome/browser/resources/md_history/browser_service.html View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_history/browser_service.js View 1 2 3 4 1 chunk +20 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_history/compiled_resources2.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_history/constants.js View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_history/synced_device_card.html View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/resources/md_history/synced_device_card.js View 1 2 3 4 2 chunks +18 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_history/synced_device_manager.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/md_history/synced_device_manager.js View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (7 generated)
calamity
https://codereview.chromium.org/2172563002/diff/1/chrome/browser/resources/md_history/synced_device_manager.js File chrome/browser/resources/md_history/synced_device_manager.js (right): https://codereview.chromium.org/2172563002/diff/1/chrome/browser/resources/md_history/synced_device_manager.js#newcode68 chrome/browser/resources/md_history/synced_device_manager.js:68: tab.windowId = windowId; I don't like adding data to ...
4 years, 5 months ago (2016-07-21 08:00:47 UTC) #4
tsergeant
https://codereview.chromium.org/2172563002/diff/1/chrome/browser/resources/md_history/browser_service.js File chrome/browser/resources/md_history/browser_service.js (right): https://codereview.chromium.org/2172563002/diff/1/chrome/browser/resources/md_history/browser_service.js#newcode61 chrome/browser/resources/md_history/browser_service.js:61: * @param {number} tabId Reorder these so they're the ...
4 years, 5 months ago (2016-07-22 03:21:17 UTC) #5
tsergeant
https://codereview.chromium.org/2172563002/diff/1/chrome/browser/resources/md_history/synced_device_card.html File chrome/browser/resources/md_history/synced_device_card.html (right): https://codereview.chromium.org/2172563002/diff/1/chrome/browser/resources/md_history/synced_device_card.html#newcode95 chrome/browser/resources/md_history/synced_device_card.html:95: on-tap="openTab_" session-id="[[tab.sessionId]]" On 2016/07/22 03:21:17, tsergeant wrote: > Can ...
4 years, 5 months ago (2016-07-22 03:22:06 UTC) #6
calamity
https://codereview.chromium.org/2172563002/diff/1/chrome/browser/resources/md_history/browser_service.js File chrome/browser/resources/md_history/browser_service.js (right): https://codereview.chromium.org/2172563002/diff/1/chrome/browser/resources/md_history/browser_service.js#newcode61 chrome/browser/resources/md_history/browser_service.js:61: * @param {number} tabId On 2016/07/22 03:21:16, tsergeant wrote: ...
4 years, 4 months ago (2016-07-27 05:22:07 UTC) #8
tsergeant
lgtm
4 years, 4 months ago (2016-07-27 05:30:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172563002/100001
4 years, 4 months ago (2016-07-27 05:32:48 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:100001)
4 years, 4 months ago (2016-07-27 06:36:57 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 06:38:37 UTC) #15
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/63780b934269e5524d7ac0d93792001b3f69ff4b
Cr-Commit-Position: refs/heads/master@{#408061}

Powered by Google App Engine
This is Rietveld 408576698