[MD History] Use openForeignSession message to open foreign session tabs.

[MD History] Use openForeignSession message to open foreign session tabs.

This CL makes the synced tabs page use the same message as the old
history page to open synced tabs. This also fixes an issue with the way
the Open All Tabs button behaves which now opens all new tabs in
separate windows.

BUG=622215
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/63780b934269e5524d7ac0d93792001b3f69ff4b
Cr-Commit-Position: refs/heads/master@{#408061}

[calamity, 2016-07-21 07:41:02]

Description was changed from

==========
[MD History] Use openForeignSession message to open foreign session tabs.

This CL makes the synced tabs page use the same message as the old
history page to open synced tabs. This also fixes an issue with the way
the Open All Tabs button behaves which now opens all new tabs in
separate windows.

BUG=622597,622215
==========

to

==========
[MD History] Use openForeignSession message to open foreign session tabs.

This CL makes the synced tabs page use the same message as the old
history page to open synced tabs. This also fixes an issue with the way
the Open All Tabs button behaves which now opens all new tabs in
separate windows.

BUG=622597,622215
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[calamity, 2016-07-21 07:58:17]

Description was changed from

==========
[MD History] Use openForeignSession message to open foreign session tabs.

This CL makes the synced tabs page use the same message as the old
history page to open synced tabs. This also fixes an issue with the way
the Open All Tabs button behaves which now opens all new tabs in
separate windows.

BUG=622597,622215
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Use openForeignSession message to open foreign session tabs.

This CL makes the synced tabs page use the same message as the old
history page to open synced tabs. This also fixes an issue with the way
the Open All Tabs button behaves which now opens all new tabs in
separate windows.

BUG=622215
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[calamity, 2016-07-21 08:00:46]

calamity@chromium.org changed reviewers:
+ tsergeant@chromium.org

[calamity, 2016-07-21 08:00:47]

https://codereview.chromium.org/2172563002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/synced_device_manager.js (right):

https://codereview.chromium.org/2172563002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/synced_device_manager.js:68: tab.windowId =
windowId;
I don't like adding data to the object here, but I'm not sure what other options
I have..

[tsergeant, 2016-07-22 03:21:17]

https://codereview.chromium.org/2172563002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/browser_service.js (right):

https://codereview.chromium.org/2172563002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/browser_service.js:61: * @param {number}
tabId
Reorder these so they're the same order as the method parameters.

https://codereview.chromium.org/2172563002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/browser_service.js:63: * @param {Event} e
Change this type to reflect that it's not any old event -- it needs to be a
special-sauce Polymer tap event.

https://codereview.chromium.org/2172563002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/synced_device_card.html (right):

https://codereview.chromium.org/2172563002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/synced_device_card.html:95:
on-tap="openTab_" session-id="[[tab.sessionId]]"
Can you use the `model` event parameter (is that it? I don't remember how it
works) to avoid sticking extra properties on the <a>.

https://codereview.chromium.org/2172563002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/synced_device_card.js (right):

https://codereview.chromium.org/2172563002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/synced_device_card.js:38: windowId: Number,
Nit: Newline between these

https://codereview.chromium.org/2172563002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/synced_device_card.js:47: openAllTabs_:
function(e) {
e is unused, you can get rid of it

https://codereview.chromium.org/2172563002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/synced_device_card.js:57: var currentTarget
= e.currentTarget;
You should be able to use `e.model` to avoid sticking extra properties on the
<a>.

https://codereview.chromium.org/2172563002/diff/1/chrome/test/data/webui/md_h...
File chrome/test/data/webui/md_history/md_history_browsertest.js (left):

https://codereview.chromium.org/2172563002/diff/1/chrome/test/data/webui/md_h...
chrome/test/data/webui/md_history/md_history_browsertest.js:125: var upgraded =
false;
You need to rebase, this line doesn't exist on master.

[tsergeant, 2016-07-22 03:22:06]

https://codereview.chromium.org/2172563002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/synced_device_card.html (right):

https://codereview.chromium.org/2172563002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/synced_device_card.html:95:
on-tap="openTab_" session-id="[[tab.sessionId]]"
On 2016/07/22 03:21:17, tsergeant wrote:
> Can you use the `model` event parameter (is that it? I don't remember how it
> works) to avoid sticking extra properties on the <a>.

Whoops, this one was meant to be deleted -- roughly the same comment is in the
js file.

[calamity, 2016-07-26 07:16:04]

Patchset #3 (id:40001) has been deleted

[calamity, 2016-07-27 05:22:07]

https://codereview.chromium.org/2172563002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/browser_service.js (right):

https://codereview.chromium.org/2172563002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/browser_service.js:61: * @param {number}
tabId
On 2016/07/22 03:21:16, tsergeant wrote:
> Reorder these so they're the same order as the method parameters.

Done.

https://codereview.chromium.org/2172563002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/browser_service.js:63: * @param {Event} e
On 2016/07/22 03:21:16, tsergeant wrote:
> Change this type to reflect that it's not any old event -- it needs to be a
> special-sauce Polymer tap event.

Moved the event extraction up a level as discussed.

https://codereview.chromium.org/2172563002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/synced_device_card.js (right):

https://codereview.chromium.org/2172563002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/synced_device_card.js:38: windowId: Number,
On 2016/07/22 03:21:17, tsergeant wrote:
> Nit: Newline between these

Done.

https://codereview.chromium.org/2172563002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/synced_device_card.js:47: openAllTabs_:
function(e) {
On 2016/07/22 03:21:17, tsergeant wrote:
> e is unused, you can get rid of it

Done.

https://codereview.chromium.org/2172563002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/synced_device_card.js:57: var currentTarget
= e.currentTarget;
On 2016/07/22 03:21:17, tsergeant wrote:
> You should be able to use `e.model` to avoid sticking extra properties on the
> <a>.

Done.

https://codereview.chromium.org/2172563002/diff/1/chrome/test/data/webui/md_h...
File chrome/test/data/webui/md_history/md_history_browsertest.js (left):

https://codereview.chromium.org/2172563002/diff/1/chrome/test/data/webui/md_h...
chrome/test/data/webui/md_history/md_history_browsertest.js:125: var upgraded =
false;
On 2016/07/22 03:21:17, tsergeant wrote:
> You need to rebase, this line doesn't exist on master.

Done.

[tsergeant, 2016-07-27 05:30:39]

lgtm

[calamity, 2016-07-27 05:32:37]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2016-07-27 05:32:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 06:36:56]

Description was changed from

==========
[MD History] Use openForeignSession message to open foreign session tabs.

This CL makes the synced tabs page use the same message as the old
history page to open synced tabs. This also fixes an issue with the way
the Open All Tabs button behaves which now opens all new tabs in
separate windows.

BUG=622215
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Use openForeignSession message to open foreign session tabs.

This CL makes the synced tabs page use the same message as the old
history page to open synced tabs. This also fixes an issue with the way
the Open All Tabs button behaves which now opens all new tabs in
separate windows.

BUG=622215
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-07-27 06:36:57]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-07-27 06:38:36]

Description was changed from

==========
[MD History] Use openForeignSession message to open foreign session tabs.

This CL makes the synced tabs page use the same message as the old
history page to open synced tabs. This also fixes an issue with the way
the Open All Tabs button behaves which now opens all new tabs in
separate windows.

BUG=622215
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Use openForeignSession message to open foreign session tabs.

This CL makes the synced tabs page use the same message as the old
history page to open synced tabs. This also fixes an issue with the way
the Open All Tabs button behaves which now opens all new tabs in
separate windows.

BUG=622215
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/63780b934269e5524d7ac0d93792001b3f69ff4b
Cr-Commit-Position: refs/heads/master@{#408061}
==========

[commit-bot: I haz the power, 2016-07-27 06:38:37]

Patchset 5 (id:??) landed as
https://crrev.com/63780b934269e5524d7ac0d93792001b3f69ff4b
Cr-Commit-Position: refs/heads/master@{#408061}