Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2159213002: Cherry-pick Skia infra fixes to m53 so that Windows and Android bots can run tests. (Closed)

Created:
4 years, 5 months ago by dogben
Modified:
4 years, 5 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@m53
Target Ref:
refs/heads/chrome/m53
Project:
skia
Visibility:
Public.

Description

Cherry-pick Skia infra fixes to m53 so that Windows and Android bots can run tests. ----- Convert SK Images to new assets format Depends on https://codereview.chromium.org/2162563002/ BUG=skia:5427 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2155163002 Review-Url: https://codereview.chromium.org/2155163002 ----- Add Android SDK asset This will allow us to use CIPD to install the Android SDK on bots. BUG=skia:5427 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2086003002 Review-Url: https://codereview.chromium.org/2086003002 ----- Convert Win toolchain to CIPD package BUG=skia:5427 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2111713003 Review-Url: https://codereview.chromium.org/2111713003 ----- NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true Committed: https://skia.googlesource.com/skia/+/af924e5c9cef4221d57967e520347f3a13f332d5

Patch Set 1 #

Patch Set 2 : Convert SK Images to new assets format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -311 lines) Patch
D SK_IMAGE_VERSION View 1 1 chunk +0 lines, -1 line 0 comments Download
D infra/bots/android_sdk.isolate View 1 chunk +0 lines, -7 lines 0 comments Download
D infra/bots/android_sdk_hash View 1 chunk +0 lines, -1 line 0 comments Download
A infra/bots/assets/android_sdk/VERSION View 1 chunk +1 line, -0 lines 0 comments Download
A + infra/bots/assets/android_sdk/common.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A infra/bots/assets/android_sdk/create.py View 1 chunk +39 lines, -0 lines 0 comments Download
A + infra/bots/assets/android_sdk/create_and_upload.py View 2 chunks +6 lines, -1 line 0 comments Download
A + infra/bots/assets/android_sdk/download.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + infra/bots/assets/android_sdk/upload.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A infra/bots/assets/skimage/VERSION View 1 1 chunk +1 line, -0 lines 0 comments Download
A + infra/bots/assets/skimage/common.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A infra/bots/assets/skimage/create.py View 1 1 chunk +38 lines, -0 lines 0 comments Download
A + infra/bots/assets/skimage/create_and_upload.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + infra/bots/assets/skimage/download.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + infra/bots/assets/skimage/upload.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A infra/bots/assets/win_toolchain/VERSION View 1 chunk +1 line, -0 lines 0 comments Download
A + infra/bots/assets/win_toolchain/common.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A infra/bots/assets/win_toolchain/create.py View 1 chunk +128 lines, -0 lines 0 comments Download
A + infra/bots/assets/win_toolchain/create_and_upload.py View 2 chunks +8 lines, -1 line 0 comments Download
A + infra/bots/assets/win_toolchain/download.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + infra/bots/assets/win_toolchain/upload.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M infra/bots/common.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
D infra/bots/download_images.py View 1 1 chunk +0 lines, -28 lines 0 comments Download
D infra/bots/images.isolate View 1 1 chunk +0 lines, -8 lines 0 comments Download
D infra/bots/isolate_android_sdk.py View 1 chunk +0 lines, -129 lines 0 comments Download
D infra/bots/isolate_win_toolchain.py View 1 chunk +0 lines, -124 lines 0 comments Download
M infra/bots/perf_skia.isolate View 1 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/test_skia.isolate View 1 1 chunk +0 lines, -1 line 0 comments Download
D infra/bots/win_toolchain.isolate View 1 chunk +0 lines, -13 lines 0 comments Download
D infra/bots/win_toolchain_hash.json View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
dogben
4 years, 5 months ago (2016-07-19 13:06:29 UTC) #4
borenet
LGTM
4 years, 5 months ago (2016-07-19 13:07:40 UTC) #5
borenet
On 2016/07/19 13:07:40, borenet wrote: > LGTM Oh, probably also want: https://skia.googlesource.com/skia/+/baaea531c249d3a13b0d04eca59b8bd0ee58d76b
4 years, 5 months ago (2016-07-19 14:30:29 UTC) #6
dogben
On 2016/07/19 at 14:30:29, borenet wrote: > On 2016/07/19 13:07:40, borenet wrote: > > LGTM ...
4 years, 5 months ago (2016-07-19 15:24:24 UTC) #8
borenet
On 2016/07/19 15:24:24, Ben Wagner wrote: > On 2016/07/19 at 14:30:29, borenet wrote: > > ...
4 years, 5 months ago (2016-07-19 15:25:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159213002/20001
4 years, 5 months ago (2016-07-19 15:54:30 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 15:54:51 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/af924e5c9cef4221d57967e520347f3a13f332d5

Powered by Google App Engine
This is Rietveld 408576698