Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2111713003: Convert Win toolchain to CIPD package (Closed)

Created:
4 years, 5 months ago by borenet2
Modified:
4 years, 5 months ago
Reviewers:
borenet, rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix implementation on Windows #

Patch Set 3 : Fix line lengths, unnecessary chmod-type stuff #

Patch Set 4 : Remove no-longer-needed win_toolchain stuff #

Patch Set 5 : Add VERSION file #

Patch Set 6 : Add Filter #

Patch Set 7 : New, stripped down, toolchain #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -143 lines) Patch
A infra/bots/assets/win_toolchain/VERSION View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
A + infra/bots/assets/win_toolchain/common.py View 2 0 chunks +-1 lines, --1 lines 0 comments Download
A infra/bots/assets/win_toolchain/create.py View 1 2 3 4 5 1 chunk +128 lines, -0 lines 0 comments Download
A + infra/bots/assets/win_toolchain/create_and_upload.py View 1 2 2 chunks +7 lines, -5 lines 0 comments Download
A + infra/bots/assets/win_toolchain/download.py View 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + infra/bots/assets/win_toolchain/upload.py View 2 0 chunks +-1 lines, --1 lines 0 comments Download
D infra/bots/isolate_win_toolchain.py View 1 2 3 1 chunk +0 lines, -124 lines 0 comments Download
D infra/bots/win_toolchain.isolate View 1 2 3 1 chunk +0 lines, -13 lines 0 comments Download
D infra/bots/win_toolchain_hash.json View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
borenet
This is currently failing due to path length limit on windows.
4 years, 5 months ago (2016-07-01 12:23:54 UTC) #3
rmistry
lgtm
4 years, 5 months ago (2016-07-01 12:24:50 UTC) #4
borenet
On 2016/07/01 12:24:50, rmistry wrote: > lgtm Uploaded patch sets 6-7, which strip out unneeded ...
4 years, 5 months ago (2016-07-15 15:03:57 UTC) #5
rmistry
lgtm
4 years, 5 months ago (2016-07-15 15:12:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111713003/120001
4 years, 5 months ago (2016-07-15 15:20:07 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 15:34:11 UTC) #10
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/f1120ea72cd04c686a11d557d3cc3d4ac47fd350

Powered by Google App Engine
This is Rietveld 408576698