Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 2155163002: Convert SK Images to new assets format (Closed)

Created:
4 years, 5 months ago by borenet2
Modified:
4 years, 5 months ago
Reviewers:
borenet, rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove more stuff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -36 lines) Patch
D SK_IMAGE_VERSION View 1 chunk +0 lines, -1 line 0 comments Download
A + infra/bots/assets/skimage/VERSION View 0 chunks +-1 lines, --1 lines 0 comments Download
A + infra/bots/assets/skimage/common.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A infra/bots/assets/skimage/create.py View 1 1 chunk +38 lines, -0 lines 0 comments Download
A + infra/bots/assets/skimage/create_and_upload.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + infra/bots/assets/skimage/download.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + infra/bots/assets/skimage/upload.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M infra/bots/common.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
D infra/bots/download_images.py View 1 1 chunk +0 lines, -28 lines 0 comments Download
D infra/bots/images.isolate View 1 1 chunk +0 lines, -8 lines 0 comments Download
M infra/bots/perf_skia.isolate View 1 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/test_skia.isolate View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
borenet
4 years, 5 months ago (2016-07-18 15:08:31 UTC) #4
rmistry
lgtm
4 years, 5 months ago (2016-07-18 15:10:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155163002/20001
4 years, 5 months ago (2016-07-18 16:00:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155163002/20001
4 years, 5 months ago (2016-07-18 17:35:48 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 17:36:49 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/baaea531c249d3a13b0d04eca59b8bd0ee58d76b

Powered by Google App Engine
This is Rietveld 408576698