Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2086003002: Add Android SDK asset (Closed)

Created:
4 years, 6 months ago by borenet2
Modified:
4 years, 5 months ago
Reviewers:
borenet, rmistry, rmistry1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@cipd
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add Android SDK asset This will allow us to use CIPD to install the Android SDK on bots. BUG=skia:5427 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2086003002 Committed: https://skia.googlesource.com/skia/+/501ca7f538f129efd27113e641ad17363920886e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -135 lines) Patch
D infra/bots/android_sdk.isolate View 1 chunk +0 lines, -7 lines 0 comments Download
D infra/bots/android_sdk_hash View 1 chunk +0 lines, -1 line 0 comments Download
A infra/bots/assets/android_sdk/VERSION View 1 chunk +1 line, -0 lines 0 comments Download
A + infra/bots/assets/android_sdk/common.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A infra/bots/assets/android_sdk/create.py View 1 chunk +39 lines, -0 lines 0 comments Download
A + infra/bots/assets/android_sdk/create_and_upload.py View 2 chunks +6 lines, -1 line 0 comments Download
A + infra/bots/assets/android_sdk/download.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + infra/bots/assets/android_sdk/upload.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D infra/bots/isolate_android_sdk.py View 1 chunk +0 lines, -129 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
borenet
Depends on https://codereview.chromium.org/2099713002/
4 years, 6 months ago (2016-06-24 14:08:29 UTC) #3
rmistry
lgtm
4 years, 6 months ago (2016-06-24 14:17:43 UTC) #5
borenet
On 2016/06/24 14:17:43, rmistry wrote: > lgtm Unfortunately this is blocked on https://github.com/luci/luci-go/issues/21.
4 years, 6 months ago (2016-06-24 14:21:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2086003002/1
4 years, 5 months ago (2016-06-30 11:59:51 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 12:20:09 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/501ca7f538f129efd27113e641ad17363920886e

Powered by Google App Engine
This is Rietveld 408576698