DevTools: keep widgets in widget hierarchy upon hide, split attach/detach cycle from show/hide.

DevTools: keep widgets in widget hierarchy upon hide, split attach/detach cycle from show/hide.

Committed: https://crrev.com/3239d5a2859023f95bb94774f77ddf903d6280cc
Cr-Commit-Position: refs/heads/master@{#406767}

[pfeldman, 2016-07-20 22:30:47]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[pfeldman, 2016-07-20 22:40:08]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 22:40:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2016-07-20 23:15:12]

Description was changed from

==========
DevTools: keep widgets in widget hierarchyi upon hide, split attach/detach cycle
from show/hide.
==========

to

==========
DevTools: keep widgets in widget hierarchy upon hide, split attach/detach cycle
from show/hide.
==========

[dgozman, 2016-07-20 23:48:23]

lgtm

https://codereview.chromium.org/2157363006/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/Widget.js (right):

https://codereview.chromium.org/2157363006/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/Widget.js:218: * @param
{?Element} parentElement
!Element

https://codereview.chromium.org/2157363006/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/Widget.js:221: attach:
function(parentElement, insertBefore)
Let's move the parameters to showWidget instead!

https://codereview.chromium.org/2157363006/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/Widget.js:287: * @return
{boolean}
Remove the return value.

https://codereview.chromium.org/2157363006/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/Widget.js:337:
parent.invalidateConstraints();
This should be in hide.

[pfeldman, 2016-07-20 23:57:52]

https://codereview.chromium.org/2157363006/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/Widget.js (right):

https://codereview.chromium.org/2157363006/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/Widget.js:218: * @param
{?Element} parentElement
On 2016/07/20 23:48:22, dgozman wrote:
> !Element

Done.

https://codereview.chromium.org/2157363006/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/Widget.js:221: attach:
function(parentElement, insertBefore)
On 2016/07/20 23:48:22, dgozman wrote:
> Let's move the parameters to showWidget instead!

Acknowledged.

https://codereview.chromium.org/2157363006/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/Widget.js:287: * @return
{boolean}
On 2016/07/20 23:48:22, dgozman wrote:
> Remove the return value.

Done.

https://codereview.chromium.org/2157363006/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/Widget.js:337:
parent.invalidateConstraints();
On 2016/07/20 23:48:22, dgozman wrote:
> This should be in hide.

Done.

[commit-bot: I haz the power, 2016-07-21 00:00:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 00:00:04]

Dry run: This issue passed the CQ dry run.

[pfeldman, 2016-07-21 04:25:28]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-07-21 04:25:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 04:33:04]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-21 04:34:44]

Description was changed from

==========
DevTools: keep widgets in widget hierarchy upon hide, split attach/detach cycle
from show/hide.
==========

to

==========
DevTools: keep widgets in widget hierarchy upon hide, split attach/detach cycle
from show/hide.

Committed: https://crrev.com/3239d5a2859023f95bb94774f77ddf903d6280cc
Cr-Commit-Position: refs/heads/master@{#406767}
==========

[commit-bot: I haz the power, 2016-07-21 04:34:45]

Patchset 3 (id:??) landed as
https://crrev.com/3239d5a2859023f95bb94774f77ddf903d6280cc
Cr-Commit-Position: refs/heads/master@{#406767}

[lushnikov, 2016-07-21 21:07:13]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2170993002/ by lushnikov@chromium.org.

The reason for reverting is: REverting as this broke devtools on Tip-of-tree

[17701:17701:0721/140403:ERROR:CONSOLE(266)] "Uncaught (in promise)
NotFoundError: Failed to execute 'insertBefore' on 'Node': The node before which
the new node is to be inserted is not a child of this node.", source:
chrome-devtools://devtools/bundled/ui/Widget.js (266)
.