Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Side by Side Diff: third_party/WebKit/LayoutTests/inspector/components/minimum-size.html

Issue 2157363006: DevTools: keep widgets in widget hierarchy upon hide, split attach/detach cycle from show/hide. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: lcean Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <html> 1 <html>
2 <head> 2 <head>
3 <script src="../../http/tests/inspector/inspector-test.js"></script> 3 <script src="../../http/tests/inspector/inspector-test.js"></script>
4 <script> 4 <script>
5 5
6 function test() 6 function test()
7 { 7 {
8 function showRootSplitWidget(splitWidget) 8 function showRootSplitWidget(splitWidget)
9 { 9 {
10 splitWidget.element.style.position = "absolute"; 10 splitWidget.element.style.position = "absolute";
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 secondSidebarWidget.setMinimumSize(60, 60); 74 secondSidebarWidget.setMinimumSize(60, 60);
75 childsplitWidget.setSidebarWidget(secondSidebarWidget); 75 childsplitWidget.setSidebarWidget(secondSidebarWidget);
76 widgets["secondSidebarWidget"] = secondSidebarWidget; 76 widgets["secondSidebarWidget"] = secondSidebarWidget;
77 dumpBoundingBoxes(widgets); 77 dumpBoundingBoxes(widgets);
78 78
79 InspectorTest.addResult("Showing sidebar"); 79 InspectorTest.addResult("Showing sidebar");
80 childsplitWidget.showBoth(); 80 childsplitWidget.showBoth();
81 dumpBoundingBoxes(widgets); 81 dumpBoundingBoxes(widgets);
82 82
83 InspectorTest.addResult("Detaching sidebar"); 83 InspectorTest.addResult("Detaching sidebar");
84 secondSidebarWidget.detach(); 84 childsplitWidget.setSidebarWidget(null);
85 delete widgets["secondSidebarWidget"]; 85 delete widgets["secondSidebarWidget"];
86 dumpBoundingBoxes(widgets); 86 dumpBoundingBoxes(widgets);
87 87
88 InspectorTest.addResult("Attaching another sidebar"); 88 InspectorTest.addResult("Attaching another sidebar");
89 var thirdSidebarWidget = new WebInspector.Widget(); 89 var thirdSidebarWidget = new WebInspector.Widget();
90 thirdSidebarWidget.setMinimumSize(80, 80); 90 thirdSidebarWidget.setMinimumSize(80, 80);
91 childsplitWidget.setSidebarWidget(thirdSidebarWidget); 91 childsplitWidget.setSidebarWidget(thirdSidebarWidget);
92 widgets["thirdSidebarWidget"] = thirdSidebarWidget; 92 widgets["thirdSidebarWidget"] = thirdSidebarWidget;
93 dumpBoundingBoxes(widgets); 93 dumpBoundingBoxes(widgets);
94 94
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 dumpBoundingBoxes(widgets); 128 dumpBoundingBoxes(widgets);
129 129
130 InspectorTest.completeTest(); 130 InspectorTest.completeTest();
131 } 131 }
132 </script> 132 </script>
133 </head> 133 </head>
134 <body onload="runTest()"> 134 <body onload="runTest()">
135 <p>Tests how widget minimum size works.</p> 135 <p>Tests how widget minimum size works.</p>
136 </body> 136 </body>
137 </html> 137 </html>
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698