third_party/WebKit/LayoutTests/inspector/components/minimum-size.html - Issue 2157363006: DevTools: keep widgets in widget hierarchy upon hide, split attach/detach cycle from show/hide.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/components/minimum-size.html

Issue 2157363006: DevTools: keep widgets in widget hierarchy upon hide, split attach/detach cycle from show/hide. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: lcean Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/inspector/components/minimum-size.html

diff --git a/third_party/WebKit/LayoutTests/inspector/components/minimum-size.html b/third_party/WebKit/LayoutTests/inspector/components/minimum-size.html

index 44466f8e2293591869f85df204c71834c17b6abb..a74bec9c39b68ef583104881f36d7deef82b68fa 100644

--- a/third_party/WebKit/LayoutTests/inspector/components/minimum-size.html

+++ b/third_party/WebKit/LayoutTests/inspector/components/minimum-size.html

@@ -81,7 +81,7 @@ function test()

dumpBoundingBoxes(widgets);

InspectorTest.addResult("Detaching sidebar");

- secondSidebarWidget.detach();

+ childsplitWidget.setSidebarWidget(null);

delete widgets["secondSidebarWidget"];

dumpBoundingBoxes(widgets);

« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js » ('j') | no next file with comments »