Add gesture type value from infobar to permission report

Add gesture type value from infobar to permission report

We are using the value of user_gesture obtained from PermissionContextBase::DecidePermission to obtain the PermissionRequestGestureType value. If user_gesture is true, we record PermissionRequestGestureType::GESTURE, otherwise PermissionRequestGestureType::NO_GESTURE.

To record PermissionIgnored, user_gesture is passed to PermissionInfobarDelegate + its subclasses.

To record other permission actions, user_gesture is passed to PermissionQueueController.

BUG=613883
Committed: https://crrev.com/a91f52aa8aba6693d89da93c2a5b26c1de8477c2
Cr-Commit-Position: refs/heads/master@{#408333}

[stefanocs, 2016-07-16 07:58:38]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-16 07:58:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-16 08:09:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-16 08:09:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stefanocs, 2016-07-16 08:18:12]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-16 08:18:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stefanocs, 2016-07-16 08:18:57]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-16 08:19:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-16 08:29:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-16 08:29:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stefanocs, 2016-07-16 08:42:36]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-16 08:42:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-16 08:45:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-16 08:45:18]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[stefanocs, 2016-07-16 08:54:51]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-16 08:54:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-16 09:04:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-16 09:04:42]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[stefanocs, 2016-07-16 09:06:24]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-16 09:06:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stefanocs, 2016-07-16 10:57:11]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-16 10:57:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-16 12:38:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-16 12:38:33]

Dry run: This issue passed the CQ dry run.

[stefanocs, 2016-07-17 23:52:50]

stefanocs@google.com changed reviewers:
+ kcarattini@chromium.org, raymes@chromium.org

[kcarattini, 2016-07-19 03:18:51]

lgtm

[raymes, 2016-07-19 05:25:30]

lgtm

https://codereview.chromium.org/2154033003/diff/140001/chrome/browser/permiss...
File chrome/browser/permissions/permission_infobar_delegate.cc (right):

https://codereview.chromium.org/2154033003/diff/140001/chrome/browser/permiss...
chrome/browser/permissions/permission_infobar_delegate.cc:14: if
(!action_taken_)
nit: add {}

[stefanocs, 2016-07-19 07:45:27]

stefanocs@google.com changed reviewers:
+ sergeyu@chromium.org, stevenjb@chromium.org, timvolodine@chromium.org

[stefanocs, 2016-07-19 07:45:28]

Thanks!

timvolodine@chromium.org: Please review changes in 
chrome/browser/geolocation

stevenjb@chromium.org: Please review changes in 
chrome/browser/notifications

sergeyu@chromium.org: Please review changes in chrome/browser/media

https://codereview.chromium.org/2154033003/diff/140001/chrome/browser/permiss...
File chrome/browser/permissions/permission_infobar_delegate.cc (right):

https://codereview.chromium.org/2154033003/diff/140001/chrome/browser/permiss...
chrome/browser/permissions/permission_infobar_delegate.cc:14: if
(!action_taken_)
On 2016/07/19 05:25:30, raymes wrote:
> nit: add {}

Done.

[stefanocs, 2016-07-19 11:05:46]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 11:06:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 11:08:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 11:08:50]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[stefanocs, 2016-07-19 13:07:46]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 13:08:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 14:20:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 14:20:51]

Dry run: This issue passed the CQ dry run.

[Sergey Ulanov, 2016-07-19 20:18:02]

lgtm

[timvolodine, 2016-07-20 13:27:40]

On 2016/07/19 20:18:02, Sergey Ulanov wrote:
> lgtm

chrome/browser/geolocation -- lgtm
stefanocs@ : is this only for UMA logging or something else as well?

[stefanocs, 2016-07-20 13:47:39]

On 2016/07/20 13:27:40, timvolodine wrote:
> On 2016/07/19 20:18:02, Sergey Ulanov wrote:
> > lgtm
> 
> chrome/browser/geolocation -- lgtm
> stefanocs@ : is this only for UMA logging or something else as well?

Thanks.

We are adding this as part of go/sb-crowd-consent.
Design doc: go/permission-action-reporting.

[stevenjb, 2016-07-20 15:54:46]

c/b/notifications lgtm

[stefanocs, 2016-07-26 05:55:36]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 05:55:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stefanocs, 2016-07-26 11:11:26]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 11:11:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 12:31:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 12:31:21]

Dry run: This issue passed the CQ dry run.

[stefanocs, 2016-07-27 03:40:15]

Description was changed from

==========
Add user gesture value from infobar to permission report

The value of user gesture can be obtained from
PermissionContextBase::DecidePermission.

To record PermissionIgnored, user_gesture is passed to PermissionInfobarDelegate
+ its subclasses

To record other permission actions, user_gesture is passed to
PermissionQueueController.

BUG=613883
==========

to

==========
Add gesture type value from infobar to permission report

We are using the value of user_gesture obtained from
PermissionContextBase::DecidePermission to obtain the
PermissionRequestGestureType value. If user_gesture is true, we record
PermissionRequestGestureType::GESTURE, otherwise
PermissionRequestGestureType::NO_GESTURE. 

To record PermissionIgnored, user_gesture is passed to PermissionInfobarDelegate
+ its subclasses.

To record other permission actions, user_gesture is passed to
PermissionQueueController.

BUG=613883
==========

[stefanocs, 2016-07-27 03:42:15]

Hi Kendra and Raymes,

Please re-review changes in chrome/browser/permissions/ since I just changed the
gesture type from bool to enum.

Thanks.

[kcarattini, 2016-07-27 03:54:53]

lgtm

https://codereview.chromium.org/2154033003/diff/320001/chrome/browser/permiss...
File chrome/browser/permissions/permission_infobar_delegate.cc (right):

https://codereview.chromium.org/2154033003/diff/320001/chrome/browser/permiss...
chrome/browser/permissions/permission_infobar_delegate.cc:15:
PermissionRequestGestureType gesture_type =
I don't think you need the extra variable since this is only used once.

[stefanocs, 2016-07-27 04:25:12]

https://codereview.chromium.org/2154033003/diff/320001/chrome/browser/permiss...
File chrome/browser/permissions/permission_infobar_delegate.cc (right):

https://codereview.chromium.org/2154033003/diff/320001/chrome/browser/permiss...
chrome/browser/permissions/permission_infobar_delegate.cc:15:
PermissionRequestGestureType gesture_type =
On 2016/07/27 03:54:53, kcarattini wrote:
> I don't think you need the extra variable since this is only used once.

Done.

[stefanocs, 2016-07-27 06:12:48]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 06:13:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 06:59:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 06:59:55]

Dry run: This issue passed the CQ dry run.

[stefanocs, 2016-07-28 01:07:37]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 01:08:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stefanocs, 2016-07-28 01:44:03]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 01:44:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 01:59:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 01:59:33]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[stefanocs, 2016-07-28 03:16:39]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 03:17:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 03:33:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 03:33:03]

Dry run: This issue passed the CQ dry run.

[stefanocs, 2016-07-28 03:46:08]

The CQ bit was checked by stefanocs@google.com

[stefanocs, 2016-07-28 03:46:09]

The patchset sent to the CQ was uploaded after l-g-t-m from raymes@chromium.org,
sergeyu@chromium.org, stevenjb@chromium.org, timvolodine@chromium.org,
kcarattini@chromium.org
Link to the patchset: https://codereview.chromium.org/2154033003/#ps370001
(title: "nit")

[commit-bot: I haz the power, 2016-07-28 03:46:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 03:52:43]

Description was changed from

==========
Add gesture type value from infobar to permission report

We are using the value of user_gesture obtained from
PermissionContextBase::DecidePermission to obtain the
PermissionRequestGestureType value. If user_gesture is true, we record
PermissionRequestGestureType::GESTURE, otherwise
PermissionRequestGestureType::NO_GESTURE. 

To record PermissionIgnored, user_gesture is passed to PermissionInfobarDelegate
+ its subclasses.

To record other permission actions, user_gesture is passed to
PermissionQueueController.

BUG=613883
==========

to

==========
Add gesture type value from infobar to permission report

We are using the value of user_gesture obtained from
PermissionContextBase::DecidePermission to obtain the
PermissionRequestGestureType value. If user_gesture is true, we record
PermissionRequestGestureType::GESTURE, otherwise
PermissionRequestGestureType::NO_GESTURE. 

To record PermissionIgnored, user_gesture is passed to PermissionInfobarDelegate
+ its subclasses.

To record other permission actions, user_gesture is passed to
PermissionQueueController.

BUG=613883
==========

[commit-bot: I haz the power, 2016-07-28 03:52:44]

Committed patchset #20 (id:370001)

[commit-bot: I haz the power, 2016-07-28 03:55:18]

Description was changed from

==========
Add gesture type value from infobar to permission report

We are using the value of user_gesture obtained from
PermissionContextBase::DecidePermission to obtain the
PermissionRequestGestureType value. If user_gesture is true, we record
PermissionRequestGestureType::GESTURE, otherwise
PermissionRequestGestureType::NO_GESTURE. 

To record PermissionIgnored, user_gesture is passed to PermissionInfobarDelegate
+ its subclasses.

To record other permission actions, user_gesture is passed to
PermissionQueueController.

BUG=613883
==========

to

==========
Add gesture type value from infobar to permission report

We are using the value of user_gesture obtained from
PermissionContextBase::DecidePermission to obtain the
PermissionRequestGestureType value. If user_gesture is true, we record
PermissionRequestGestureType::GESTURE, otherwise
PermissionRequestGestureType::NO_GESTURE.

To record PermissionIgnored, user_gesture is passed to PermissionInfobarDelegate
+ its subclasses.

To record other permission actions, user_gesture is passed to
PermissionQueueController.

BUG=613883

Committed: https://crrev.com/a91f52aa8aba6693d89da93c2a5b26c1de8477c2
Cr-Commit-Position: refs/heads/master@{#408333}
==========

[commit-bot: I haz the power, 2016-07-28 03:55:20]

Patchset 20 (id:??) landed as
https://crrev.com/a91f52aa8aba6693d89da93c2a5b26c1de8477c2
Cr-Commit-Position: refs/heads/master@{#408333}