Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Unified Diff: chrome/browser/permissions/permission_queue_controller_unittest.cc

Issue 2154033003: Add gesture type value from infobar to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-user-gesture-from-permission-layer-to-permission-report
Patch Set: nit Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/permissions/permission_queue_controller.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_queue_controller_unittest.cc
diff --git a/chrome/browser/permissions/permission_queue_controller_unittest.cc b/chrome/browser/permissions/permission_queue_controller_unittest.cc
index 8f1b25474d2f21499dc04e50f10d748de751594f..f2b3a2dbd0109c82f4af628bc04f1b125401c1eb 100644
--- a/chrome/browser/permissions/permission_queue_controller_unittest.cc
+++ b/chrome/browser/permissions/permission_queue_controller_unittest.cc
@@ -99,10 +99,10 @@ TEST_F(PermissionQueueControllerTests, OneObservationPerInfoBarCancelled) {
ObservationCountingQueueController queue_controller(profile());
GURL url("http://www.example.com/geolocation");
base::Callback<void(ContentSetting)> callback;
- queue_controller.CreateInfoBarRequest(
- RequestID(0), url, url, callback);
- queue_controller.CreateInfoBarRequest(
- RequestID(1), url, url, callback);
+ queue_controller.CreateInfoBarRequest(RequestID(0), url, url,
+ false /* user_gesture */, callback);
+ queue_controller.CreateInfoBarRequest(RequestID(1), url, url,
+ false /* user_gesture */, callback);
queue_controller.CancelInfoBarRequest(RequestID(0));
EXPECT_EQ(1, queue_controller.call_count());
}
@@ -111,8 +111,8 @@ TEST_F(PermissionQueueControllerTests, FailOnBadPattern) {
ObservationCountingQueueController queue_controller(profile());
GURL url("chrome://settings");
base::Callback<void(ContentSetting)> callback;
- queue_controller.CreateInfoBarRequest(
- RequestID(0), url, url, callback);
+ queue_controller.CreateInfoBarRequest(RequestID(0), url, url,
+ false /* user_gesture */, callback);
queue_controller.CancelInfoBarRequest(RequestID(0));
EXPECT_EQ(0, queue_controller.call_count());
}
« no previous file with comments | « chrome/browser/permissions/permission_queue_controller.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698