Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3463)

Unified Diff: chrome/browser/permissions/permission_context_base.cc

Issue 2154033003: Add gesture type value from infobar to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-user-gesture-from-permission-layer-to-permission-report
Patch Set: nit Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_context_base.cc
diff --git a/chrome/browser/permissions/permission_context_base.cc b/chrome/browser/permissions/permission_context_base.cc
index 206b383cf8eae25ac9ff1020eb7cd1b2c8674f1b..8ce7f18b287fe0885a835bc862d313c02bbf2370 100644
--- a/chrome/browser/permissions/permission_context_base.cc
+++ b/chrome/browser/permissions/permission_context_base.cc
@@ -191,10 +191,8 @@ void PermissionContextBase::DecidePermission(
DCHECK(inserted) << "Duplicate id " << id.ToString();
permission_request_manager->AddRequest(request);
#else
- // TODO(stefanocs): Pass |user_gesture| to CreateInfoBarRequest to record
- // permission actions in infobar.
GetQueueController()->CreateInfoBarRequest(
- id, requesting_origin, embedding_origin,
+ id, requesting_origin, embedding_origin, user_gesture,
base::Bind(&PermissionContextBase::PermissionDecided,
weak_factory_.GetWeakPtr(), id, requesting_origin,
embedding_origin, user_gesture, callback,

Powered by Google App Engine
This is Rietveld 408576698