chrome/browser/geolocation/geolocation_infobar_delegate_android.cc - Issue 2154033003: Add gesture type value from infobar to permission report

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/geolocation_infobar_delegate_android.cc

Issue 2154033003: Add gesture type value from infobar to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-user-gesture-from-permission-layer-to-permission-report

Patch Set: nit Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/geolocation/geolocation_infobar_delegate_android.h ('k') | chrome/browser/media/midi_permission_infobar_delegate_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/geolocation/geolocation_infobar_delegate_android.cc

diff --git a/chrome/browser/geolocation/geolocation_infobar_delegate_android.cc b/chrome/browser/geolocation/geolocation_infobar_delegate_android.cc

index b67b268dd3f0ea7f5a891e81c03edda2ff406f7b..780c70cfd61898c6f623b7041fca6b7bb9637cb1 100644

--- a/chrome/browser/geolocation/geolocation_infobar_delegate_android.cc

+++ b/chrome/browser/geolocation/geolocation_infobar_delegate_android.cc

@@ -14,21 +14,24 @@

infobars::InfoBar* GeolocationInfoBarDelegateAndroid::Create(

InfoBarService* infobar_service,

const GURL& requesting_frame,

+ bool user_gesture,

Profile* profile,

const PermissionSetCallback& callback) {

return infobar_service->AddInfoBar(infobar_service->CreateConfirmInfoBar(

std::unique_ptr<ConfirmInfoBarDelegate>(

- new GeolocationInfoBarDelegateAndroid(requesting_frame, profile,

- callback))));

+ new GeolocationInfoBarDelegateAndroid(requesting_frame, user_gesture,

+ profile, callback))));

}

GeolocationInfoBarDelegateAndroid::GeolocationInfoBarDelegateAndroid(

const GURL& requesting_frame,

+ bool user_gesture,

Profile* profile,

const PermissionSetCallback& callback)

: PermissionInfobarDelegate(requesting_frame,

content::PermissionType::GEOLOCATION,

CONTENT_SETTINGS_TYPE_GEOLOCATION,

+ user_gesture,

profile,

callback),

requesting_frame_(requesting_frame) {}