chrome/browser/permissions/permission_request_impl.cc - Issue 2153133002: Add gesture type value from desktop prompt to permission report

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_request_impl.cc

Issue 2153133002: Add gesture type value from desktop prompt to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-user-gesture-to-reporting-part

Patch Set: nit Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/permissions/permission_request_impl.cc

diff --git a/chrome/browser/permissions/permission_request_impl.cc b/chrome/browser/permissions/permission_request_impl.cc

index da4c6495591fac42213fc2797c1b0314537e6d2b..4faf00eb8e78c14f7a3cce54760b15172c5f94a7 100644

--- a/chrome/browser/permissions/permission_request_impl.cc

+++ b/chrome/browser/permissions/permission_request_impl.cc

@@ -33,8 +33,8 @@ PermissionRequestImpl::PermissionRequestImpl(

PermissionRequestImpl::~PermissionRequestImpl() {

DCHECK(is_finished_);

if (!action_taken_) {

- PermissionUmaUtil::PermissionIgnored(permission_type_, request_origin_,

- profile_);

+ PermissionUmaUtil::PermissionIgnored(permission_type_, GetGestureType(),

+ request_origin_, profile_);

}

« no previous file with comments | « chrome/browser/permissions/permission_queue_controller.cc ('k') | chrome/browser/permissions/permission_uma_util.h » ('j') | no next file with comments »