Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3043)

Unified Diff: chrome/browser/permissions/permission_queue_controller.cc

Issue 2153133002: Add gesture type value from desktop prompt to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-user-gesture-to-reporting-part
Patch Set: nit Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_queue_controller.cc
diff --git a/chrome/browser/permissions/permission_queue_controller.cc b/chrome/browser/permissions/permission_queue_controller.cc
index 161e04a10e95ba1f9aa7e04b4566b523cd91aa17..3ea8d9fe6340dcee3a7b1eecae1b13d9620ae31a 100644
--- a/chrome/browser/permissions/permission_queue_controller.cc
+++ b/chrome/browser/permissions/permission_queue_controller.cc
@@ -11,6 +11,7 @@
#include "chrome/browser/media/midi_permission_infobar_delegate_android.h"
#include "chrome/browser/media/protected_media_identifier_infobar_delegate_android.h"
#include "chrome/browser/notifications/notification_permission_infobar_delegate.h"
+#include "chrome/browser/permissions/permission_request.h"
#include "chrome/browser/permissions/permission_request_id.h"
#include "chrome/browser/permissions/permission_uma_util.h"
#include "chrome/browser/profiles/profile.h"
@@ -206,17 +207,22 @@ void PermissionQueueController::OnPermissionSet(
// TODO(miguelg): move the permission persistence to
// PermissionContextBase once all the types are moved there.
+ // TODO(stefanocs): Pass the actual |gesture_type| value to PermissionUmaUtil.
if (update_content_setting) {
UpdateContentSetting(requesting_frame, embedder, allowed);
- if (allowed)
- PermissionUmaUtil::PermissionGranted(permission_type_, requesting_frame,
- profile_);
- else
- PermissionUmaUtil::PermissionDenied(permission_type_, requesting_frame,
- profile_);
+ if (allowed) {
+ PermissionUmaUtil::PermissionGranted(
+ permission_type_, PermissionRequestGestureType::UNKNOWN,
+ requesting_frame, profile_);
+ } else {
+ PermissionUmaUtil::PermissionDenied(permission_type_,
+ PermissionRequestGestureType::UNKNOWN,
+ requesting_frame, profile_);
+ }
} else {
- PermissionUmaUtil::PermissionDismissed(permission_type_, requesting_frame,
- profile_);
+ PermissionUmaUtil::PermissionDismissed(
+ permission_type_, PermissionRequestGestureType::UNKNOWN,
+ requesting_frame, profile_);
}
// Cancel this request first, then notify listeners. TODO(pkasting): Why
« no previous file with comments | « chrome/browser/permissions/permission_infobar_delegate.cc ('k') | chrome/browser/permissions/permission_request_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698