Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: chrome/browser/permissions/permission_uma_util.h

Issue 2153133002: Add gesture type value from desktop prompt to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-user-gesture-to-reporting-part
Patch Set: nit Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_uma_util.h
diff --git a/chrome/browser/permissions/permission_uma_util.h b/chrome/browser/permissions/permission_uma_util.h
index d56a9f070f77275e12d5c2f77e5aeffacf9594c1..4ce425c7a07df07ed9a985112dd23805ccab9c6e 100644
--- a/chrome/browser/permissions/permission_uma_util.h
+++ b/chrome/browser/permissions/permission_uma_util.h
@@ -10,6 +10,7 @@
#include "base/logging.h"
#include "base/macros.h"
+enum class PermissionRequestGestureType;
class GURL;
class Profile;
@@ -69,15 +70,19 @@ class PermissionUmaUtil {
const GURL& embedding_origin,
Profile* profile);
static void PermissionGranted(content::PermissionType permission,
+ PermissionRequestGestureType gesture_type,
const GURL& requesting_origin,
Profile* profile);
static void PermissionDenied(content::PermissionType permission,
+ PermissionRequestGestureType gesture_type,
const GURL& requesting_origin,
Profile* profile);
static void PermissionDismissed(content::PermissionType permission,
+ PermissionRequestGestureType gesture_type,
const GURL& requesting_origin,
Profile* profile);
static void PermissionIgnored(content::PermissionType permission,
+ PermissionRequestGestureType gesture_type,
const GURL& requesting_origin,
Profile* profile);
static void PermissionRevoked(content::PermissionType permission,
@@ -117,6 +122,7 @@ class PermissionUmaUtil {
static void RecordPermissionAction(content::PermissionType permission,
PermissionAction action,
PermissionSourceUI source_ui,
+ PermissionRequestGestureType gesture_type,
const GURL& requesting_origin,
Profile* profile);
« no previous file with comments | « chrome/browser/permissions/permission_request_impl.cc ('k') | chrome/browser/permissions/permission_uma_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698