Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: chrome/browser/permissions/permission_request_impl.cc

Issue 2153133002: Add gesture type value from desktop prompt to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-user-gesture-to-reporting-part
Patch Set: nit Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/permissions/permission_request_impl.h" 5 #include "chrome/browser/permissions/permission_request_impl.h"
6 6
7 #include "build/build_config.h" 7 #include "build/build_config.h"
8 #include "chrome/browser/permissions/permission_context_base.h" 8 #include "chrome/browser/permissions/permission_context_base.h"
9 #include "chrome/browser/permissions/permission_uma_util.h" 9 #include "chrome/browser/permissions/permission_uma_util.h"
10 #include "chrome/grit/generated_resources.h" 10 #include "chrome/grit/generated_resources.h"
(...skipping 15 matching lines...) Expand all
26 profile_(profile), 26 profile_(profile),
27 has_gesture_(has_gesture), 27 has_gesture_(has_gesture),
28 permission_decided_callback_(permission_decided_callback), 28 permission_decided_callback_(permission_decided_callback),
29 delete_callback_(delete_callback), 29 delete_callback_(delete_callback),
30 is_finished_(false), 30 is_finished_(false),
31 action_taken_(false) {} 31 action_taken_(false) {}
32 32
33 PermissionRequestImpl::~PermissionRequestImpl() { 33 PermissionRequestImpl::~PermissionRequestImpl() {
34 DCHECK(is_finished_); 34 DCHECK(is_finished_);
35 if (!action_taken_) { 35 if (!action_taken_) {
36 PermissionUmaUtil::PermissionIgnored(permission_type_, request_origin_, 36 PermissionUmaUtil::PermissionIgnored(permission_type_, GetGestureType(),
37 profile_); 37 request_origin_, profile_);
38 } 38 }
39 } 39 }
40 40
41 gfx::VectorIconId PermissionRequestImpl::GetVectorIconId() const { 41 gfx::VectorIconId PermissionRequestImpl::GetVectorIconId() const {
42 #if !defined(OS_MACOSX) && !defined(OS_ANDROID) 42 #if !defined(OS_MACOSX) && !defined(OS_ANDROID)
43 switch (permission_type_) { 43 switch (permission_type_) {
44 case content::PermissionType::GEOLOCATION: 44 case content::PermissionType::GEOLOCATION:
45 return gfx::VectorIconId::LOCATION_ON; 45 return gfx::VectorIconId::LOCATION_ON;
46 #if defined(ENABLE_NOTIFICATIONS) 46 #if defined(ENABLE_NOTIFICATIONS)
47 case content::PermissionType::NOTIFICATIONS: 47 case content::PermissionType::NOTIFICATIONS:
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 NOTREACHED(); 159 NOTREACHED();
160 return PermissionRequestType::UNKNOWN; 160 return PermissionRequestType::UNKNOWN;
161 } 161 }
162 } 162 }
163 163
164 PermissionRequestGestureType PermissionRequestImpl::GetGestureType() 164 PermissionRequestGestureType PermissionRequestImpl::GetGestureType()
165 const { 165 const {
166 return has_gesture_ ? PermissionRequestGestureType::GESTURE 166 return has_gesture_ ? PermissionRequestGestureType::GESTURE
167 : PermissionRequestGestureType::NO_GESTURE; 167 : PermissionRequestGestureType::NO_GESTURE;
168 } 168 }
OLDNEW
« no previous file with comments | « chrome/browser/permissions/permission_queue_controller.cc ('k') | chrome/browser/permissions/permission_uma_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698