Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2152683003: Revert "VM: Array bounds checks that don't deoptimize for precompiled code." (Closed)

Created:
4 years, 5 months ago by rmacnak
Modified:
4 years, 5 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "VM: Array bounds checks that don't deoptimize for precompiled code." This reverts commit 4a5f651c4b2202013ab7c3db887fd95e2597e173. Committed: https://github.com/dart-lang/sdk/commit/2a535414bc412440208f34d10cb19ecc808dbc5d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -446 lines) Patch
M runtime/vm/aot_optimizer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/aot_optimizer.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M runtime/vm/assembler_arm.h View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/assembler_arm64.h View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/assembler_ia32.h View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/assembler_mips.h View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/assembler_x64.h View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/code_generator.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M runtime/vm/constant_propagator.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 3 chunks +27 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_type_propagator.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_type_propagator.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M runtime/vm/intermediate_language.h View 2 chunks +0 lines, -30 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 5 chunks +2 lines, -72 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 4 chunks +2 lines, -73 lines 0 comments Download
M runtime/vm/intermediate_language_dbc.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 4 chunks +2 lines, -25 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 5 chunks +2 lines, -71 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 5 chunks +2 lines, -72 lines 0 comments Download
M runtime/vm/intrinsifier.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/precompiler.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/runtime_entry_list.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 5 months ago (2016-07-14 20:26:41 UTC) #2
rmacnak
Committed patchset #1 (id:1) manually as 2a535414bc412440208f34d10cb19ecc808dbc5d (presubmit successful).
4 years, 5 months ago (2016-07-14 20:28:28 UTC) #4
Florian Schneider
4 years, 5 months ago (2016-07-15 00:18:20 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698