runtime/vm/flow_graph_type_propagator.cc - Issue 2152683003: Revert "VM: Array bounds checks that don't deoptimize for precompiled code."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_type_propagator.cc

Issue 2152683003: Revert "VM: Array bounds checks that don't deoptimize for precompiled code." (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_type_propagator.cc

diff --git a/runtime/vm/flow_graph_type_propagator.cc b/runtime/vm/flow_graph_type_propagator.cc

index 2162cfed4e9f175bcd6d3796fc75963cf9353261..2ee8ed12520d69003970ed9446da48be58a76ca4 100644

--- a/runtime/vm/flow_graph_type_propagator.cc

+++ b/runtime/vm/flow_graph_type_propagator.cc

@@ -237,13 +237,6 @@ void FlowGraphTypePropagator::VisitCheckSmi(CheckSmiInstr* check) {

}

-void FlowGraphTypePropagator::VisitCheckArrayBound(

- CheckArrayBoundInstr* check) {

- // Array bounds checks also test index for smi.

- SetCid(check->index()->definition(), kSmiCid);

void FlowGraphTypePropagator::VisitCheckClass(CheckClassInstr* check) {

if ((check->unary_checks().NumberOfChecks() != 1) ||

!check->Dependencies().IsNone()) {

« no previous file with comments | « runtime/vm/flow_graph_type_propagator.h ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »