runtime/vm/assembler_x64.h - Issue 2152683003: Revert "VM: Array bounds checks that don't deoptimize for precompiled code."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/assembler_x64.h

Issue 2152683003: Revert "VM: Array bounds checks that don't deoptimize for precompiled code." (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/assembler_x64.h

diff --git a/runtime/vm/assembler_x64.h b/runtime/vm/assembler_x64.h

index f4ce1322db3769e491a87268ec71fee92904328e..c865814f3a1c3c37e8ca31c0beb68f39d23251f5 100644

--- a/runtime/vm/assembler_x64.h

+++ b/runtime/vm/assembler_x64.h

@@ -861,11 +861,6 @@ class Assembler : public ValueObject {

sarq(reg, Immediate(kSmiTagSize));

}

- void BranchIfNotSmi(Register reg, Label* label) {

- testq(reg, Immediate(kSmiTagMask));

- j(NOT_ZERO, label);

- }

void Align(int alignment, intptr_t offset);

void Bind(Label* label);

void Jump(Label* label) { jmp(label); }

« no previous file with comments | « runtime/vm/assembler_mips.h ('k') | runtime/vm/code_generator.cc » ('j') | no next file with comments »