runtime/vm/assembler_mips.h - Issue 2152683003: Revert "VM: Array bounds checks that don't deoptimize for precompiled code."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/assembler_mips.h

Issue 2152683003: Revert "VM: Array bounds checks that don't deoptimize for precompiled code." (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/assembler_mips.h

diff --git a/runtime/vm/assembler_mips.h b/runtime/vm/assembler_mips.h

index 87717b656cdaec326d7fd12e563167a35dcbbbe7..a3cbebbb099b410b07c75b170ebc7192e90b29ef 100644

--- a/runtime/vm/assembler_mips.h

+++ b/runtime/vm/assembler_mips.h

@@ -1472,11 +1472,6 @@ class Assembler : public ValueObject {

sra(dst, src, kSmiTagSize);

}

- void BranchIfNotSmi(Register reg, Label* label) {

- andi(CMPRES1, reg, Immediate(kSmiTagMask));

- bne(CMPRES1, ZR, label);

- }

void LoadFromOffset(Register reg, Register base, int32_t offset) {

ASSERT(!in_delay_slot_);

if (Utils::IsInt(kImmBits, offset)) {

« no previous file with comments | « runtime/vm/assembler_ia32.h ('k') | runtime/vm/assembler_x64.h » ('j') | no next file with comments »