tools/gn/visual_studio_writer.h - Issue 2152413002: GN: don't write separate files for non-binary targets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/visual_studio_writer.h

Issue 2152413002: GN: don't write separate files for non-binary targets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: typo Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/visual_studio_writer.h

diff --git a/tools/gn/visual_studio_writer.h b/tools/gn/visual_studio_writer.h

index 99c537075fffbeebfa9c0543c231a1e8d2e48da2..0a8fcb45acaada2d514d9673b4c8c7fa50c63c79 100644

--- a/tools/gn/visual_studio_writer.h

+++ b/tools/gn/visual_studio_writer.h

@@ -37,7 +37,7 @@ class VisualStudioWriter {

// of generated projects. Only matching targets will be included to the

// solution. On failure will populate |err| and will return false.

static bool RunAndWriteFiles(const BuildSettings* build_settings,

- Builder* builder,

+ const Builder& builder,

Version version,

const std::string& sln_name,

const std::string& dir_filters,

« no previous file with comments | « tools/gn/toolchain.h ('k') | tools/gn/visual_studio_writer.cc » ('j') | no next file with comments »