Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Unified Diff: tools/gn/toolchain.h

Issue 2152413002: GN: don't write separate files for non-binary targets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: typo Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/setup.cc ('k') | tools/gn/visual_studio_writer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/toolchain.h
diff --git a/tools/gn/toolchain.h b/tools/gn/toolchain.h
index 76858dea0033f622e6b2b9f8d625a1bf20e4eaa3..4ccfdc8c699bcde4e4fa58f5f2bc4bc10671b95f 100644
--- a/tools/gn/toolchain.h
+++ b/tools/gn/toolchain.h
@@ -66,6 +66,15 @@ class Toolchain : public Item {
static const char* kToolCopyBundleData;
static const char* kToolCompileXCAssets;
+ // The Settings of an Item is always the context in which the Item was
+ // defined. For a toolchain this is confusing because this is NOT the
+ // settings object that applies to the things in the toolchain.
+ //
+ // To get the Settings object corresponding to objects loaded in the context
+ // of this toolchain (probably what you want instead), see
+ // Loader::GetToolchainSettings(). Many toolchain objects may be created in a
+ // given build, but only a few might be used, and the Loader is in charge of
+ // this process.
Toolchain(const Settings* settings, const Label& label);
~Toolchain() override;
« no previous file with comments | « tools/gn/setup.cc ('k') | tools/gn/visual_studio_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698