Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: tools/gn/visual_studio_writer.h

Issue 2152413002: GN: don't write separate files for non-binary targets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: typo Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/gn/toolchain.h ('k') | tools/gn/visual_studio_writer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef TOOLS_GN_VISUAL_STUDIO_WRITER_H_ 5 #ifndef TOOLS_GN_VISUAL_STUDIO_WRITER_H_
6 #define TOOLS_GN_VISUAL_STUDIO_WRITER_H_ 6 #define TOOLS_GN_VISUAL_STUDIO_WRITER_H_
7 7
8 #include <iosfwd> 8 #include <iosfwd>
9 #include <memory> 9 #include <memory>
10 #include <string> 10 #include <string>
(...skipping 19 matching lines...) Expand all
30 Vs2013 = 1, // Visual Studio 2013 30 Vs2013 = 1, // Visual Studio 2013
31 Vs2015 // Visual Studio 2015 31 Vs2015 // Visual Studio 2015
32 }; 32 };
33 33
34 // Writes Visual Studio project and solution files. |sln_name| is the optional 34 // Writes Visual Studio project and solution files. |sln_name| is the optional
35 // solution file name ("all" is used if not specified). |dir_filters| is 35 // solution file name ("all" is used if not specified). |dir_filters| is
36 // optional semicolon-separated list of label patterns used to limit the set 36 // optional semicolon-separated list of label patterns used to limit the set
37 // of generated projects. Only matching targets will be included to the 37 // of generated projects. Only matching targets will be included to the
38 // solution. On failure will populate |err| and will return false. 38 // solution. On failure will populate |err| and will return false.
39 static bool RunAndWriteFiles(const BuildSettings* build_settings, 39 static bool RunAndWriteFiles(const BuildSettings* build_settings,
40 Builder* builder, 40 const Builder& builder,
41 Version version, 41 Version version,
42 const std::string& sln_name, 42 const std::string& sln_name,
43 const std::string& dir_filters, 43 const std::string& dir_filters,
44 Err* err); 44 Err* err);
45 45
46 private: 46 private:
47 FRIEND_TEST_ALL_PREFIXES(VisualStudioWriterTest, ResolveSolutionFolders); 47 FRIEND_TEST_ALL_PREFIXES(VisualStudioWriterTest, ResolveSolutionFolders);
48 FRIEND_TEST_ALL_PREFIXES(VisualStudioWriterTest, 48 FRIEND_TEST_ALL_PREFIXES(VisualStudioWriterTest,
49 ResolveSolutionFolders_AbsPath); 49 ResolveSolutionFolders_AbsPath);
50 50
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 // Semicolon-separated Windows SDK include directories. 144 // Semicolon-separated Windows SDK include directories.
145 std::string windows_kits_include_dirs_; 145 std::string windows_kits_include_dirs_;
146 146
147 // Path formatter for ninja targets. 147 // Path formatter for ninja targets.
148 PathOutput ninja_path_output_; 148 PathOutput ninja_path_output_;
149 149
150 DISALLOW_COPY_AND_ASSIGN(VisualStudioWriter); 150 DISALLOW_COPY_AND_ASSIGN(VisualStudioWriter);
151 }; 151 };
152 152
153 #endif // TOOLS_GN_VISUAL_STUDIO_WRITER_H_ 153 #endif // TOOLS_GN_VISUAL_STUDIO_WRITER_H_
OLDNEW
« no previous file with comments | « tools/gn/toolchain.h ('k') | tools/gn/visual_studio_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698