Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: tools/gn/visual_studio_writer.cc

Issue 2152413002: GN: don't write separate files for non-binary targets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: typo Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/visual_studio_writer.h ('k') | tools/gn/xcode_writer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/visual_studio_writer.cc
diff --git a/tools/gn/visual_studio_writer.cc b/tools/gn/visual_studio_writer.cc
index 401782f5217434c4d6965e5211e54c71ea4ed8b9..fb6d923db0a02ec61d669ca8c1d33db62294defc 100644
--- a/tools/gn/visual_studio_writer.cc
+++ b/tools/gn/visual_studio_writer.cc
@@ -166,12 +166,12 @@ base::StringPiece FindParentDir(const std::string* path) {
}
bool FilterTargets(const BuildSettings* build_settings,
- Builder* builder,
+ const Builder& builder,
const std::string& dir_filters,
std::vector<const Target*>* targets,
Err* err) {
if (dir_filters.empty()) {
- *targets = builder->GetAllResolvedTargets();
+ *targets = builder.GetAllResolvedTargets();
return true;
}
@@ -180,7 +180,7 @@ bool FilterTargets(const BuildSettings* build_settings,
err))
return false;
- commands::FilterTargetsByPatterns(builder->GetAllResolvedTargets(), filters,
+ commands::FilterTargetsByPatterns(builder.GetAllResolvedTargets(), filters,
targets);
std::set<Label> labels;
@@ -269,7 +269,7 @@ VisualStudioWriter::~VisualStudioWriter() {
// static
bool VisualStudioWriter::RunAndWriteFiles(const BuildSettings* build_settings,
- Builder* builder,
+ const Builder& builder,
Version version,
const std::string& sln_name,
const std::string& dir_filters,
« no previous file with comments | « tools/gn/visual_studio_writer.h ('k') | tools/gn/xcode_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698