Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2151383002: MD Settings: Use <button class="dropdown-item"> for drop-down options. (Closed)

Created:
4 years, 5 months ago by dpapad
Modified:
4 years, 5 months ago
Reviewers:
stevenjb
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Use <button class="dropdown-item"> for drop-down options. BUG=626989 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/bb3837ca9b2cf9f46f0559f4782743ea5cb384d0 Cr-Commit-Position: refs/heads/master@{#405869}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M chrome/browser/resources/settings/device_page/display.html View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/media_picker.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_data_details_dialog.html View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_details_permission.html View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dpapad
@Steven: This CL converts all dropdown items except a few under passwords_and_forms_page/ which I'll address ...
4 years, 5 months ago (2016-07-15 21:20:52 UTC) #6
stevenjb
Thanks! LGTM
4 years, 5 months ago (2016-07-15 21:22:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151383002/1
4 years, 5 months ago (2016-07-15 21:31:05 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 21:52:08 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 21:53:31 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb3837ca9b2cf9f46f0559f4782743ea5cb384d0
Cr-Commit-Position: refs/heads/master@{#405869}

Powered by Google App Engine
This is Rietveld 408576698