chrome/browser/resources/settings/site_settings/site_details_permission.html - Issue 2151383002: MD Settings: Use <button class="dropdown-item"> for drop-down options.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/site_settings/site_details_permission.html

Issue 2151383002: MD Settings: Use <button class="dropdown-item"> for drop-down options. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/settings/site_settings/site_details_permission.html

diff --git a/chrome/browser/resources/settings/site_settings/site_details_permission.html b/chrome/browser/resources/settings/site_settings/site_details_permission.html

index a18cbdc831f140b84a9a3ad15888e0d94e4ba01e..89ca83bd28451c98f51b43a339e699cc9d2e3ef3 100644

--- a/chrome/browser/resources/settings/site_settings/site_details_permission.html

+++ b/chrome/browser/resources/settings/site_settings/site_details_permission.html

@@ -60,14 +60,14 @@

<paper-listbox id="permission" class="dropdown-content"

on-iron-activate="onPermissionMenuIronActivate_"

attr-for-selected="data-permission-value">

- <div id="allow" class="dropdown-item" role="option"

+ <button id="allow" class="dropdown-item" role="option"

data-permission-value$="[[PermissionValues.ALLOW]]">

[[i18n_.allowAction]]

- </div>

- <div id="block" class="dropdown-item" role="option"

+ </button>

+ <button id="block" class="dropdown-item" role="option"

data-permission-value$="[[PermissionValues.BLOCK]]">

[[i18n_.blockAction]]

- </div>

+ </button>

</paper-listbox>

</paper-dropdown-menu>

</div>

« no previous file with comments | « chrome/browser/resources/settings/site_settings/site_data_details_dialog.html ('k') | no next file » | no next file with comments »