chrome/browser/resources/settings/device_page/display.html - Issue 2151383002: MD Settings: Use <button class="dropdown-item"> for drop-down options.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/device_page/display.html

Issue 2151383002: MD Settings: Use <button class="dropdown-item"> for drop-down options. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/settings/device_page/display.html

diff --git a/chrome/browser/resources/settings/device_page/display.html b/chrome/browser/resources/settings/device_page/display.html

index 04cdcb15ad67cae332f85fdd1c83c8f2bba112d1..1f4186e57276923c39b571167f6c1a1d28a44150 100644

--- a/chrome/browser/resources/settings/device_page/display.html

+++ b/chrome/browser/resources/settings/device_page/display.html

@@ -88,12 +88,12 @@

selected="[[selectedDisplay.rotation]]"

attr-for-selected="value"

on-iron-activate="onSetOrientation_">

- <div class="dropdown-item" value="0">

+ <button class="dropdown-item" role="option" value="0">

$i18n{displayOrientationStandard}

- </div>

- <div class="dropdown-item" value="90">90</div>

- <div class="dropdown-item" value="180">180</div>

- <div class="dropdown-item" value="270">270</div>

+ </button>

+ <button class="dropdown-item" role="option" value="90">90</button>

+ <button class="dropdown-item" role="option" value="180">180</button>

+ <button class="dropdown-item" role="option" value="270">270</button>

</paper-listbox>

</paper-dropdown-menu>

</div>

« no previous file with comments | « no previous file | chrome/browser/resources/settings/site_settings/media_picker.html » ('j') | no next file with comments »