chrome/browser/resources/settings/site_settings/media_picker.html - Issue 2151383002: MD Settings: Use <button class="dropdown-item"> for drop-down options.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/site_settings/media_picker.html

Issue 2151383002: MD Settings: Use <button class="dropdown-item"> for drop-down options. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/settings/device_page/display.html ('k') | chrome/browser/resources/settings/site_settings/site_data_details_dialog.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/html/polymer.html">	1 <link rel="import" href="chrome://resources/html/polymer.html">

2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-dropdown-menu/pap er-dropdown-menu.html">	2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-dropdown-menu/pap er-dropdown-menu.html">

3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-listbox/paper-lis tbox.html">	3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-listbox/paper-lis tbox.html">

4 <link rel="import" href="/settings_shared_css.html">	4 <link rel="import" href="/settings_shared_css.html">

5	5

6 <dom-module id="media-picker">	6 <dom-module id="media-picker">

7 <template>	7 <template>

8 <style include="settings-shared">	8 <style include="settings-shared">

9 :host {	9 :host {

10 display: block;	10 display: block;

11 }	11 }

12 </style>	12 </style>

13 <div class="settings-box" id="picker" hidden>	13 <div class="settings-box" id="picker" hidden>

14 <paper-dropdown-menu>	14 <paper-dropdown-menu>

15 <paper-listbox id="mediaPicker" class="dropdown-content"	15 <paper-listbox id="mediaPicker" class="dropdown-content"

16 attr-for-selected="media-picker-value"	16 attr-for-selected="media-picker-value"

17 on-iron-activate="onMediaPickerActivate_">	17 on-iron-activate="onMediaPickerActivate_">

18 <template is="dom-repeat" items="[[devices]]">	18 <template is="dom-repeat" items="[[devices]]">

19 <div class="dropdown-item" role="option"	19 <button class="dropdown-item" role="option"

20 media-picker-value$="[[item.id]]">	20 media-picker-value$="[[item.id]]">

21 [[item.name]]	21 [[item.name]]

22 </div>	22 </button>

23 </template>	23 </template>

24 </paper-listbox>	24 </paper-listbox>

25 </paper-dropdown-menu>	25 </paper-dropdown-menu>

26 </div>	26 </div>

27 </template>	27 </template>

28 <script src="media_picker.js"></script>	28 <script src="media_picker.js"></script>

29 </dom-module>	29 </dom-module>

OLD	NEW