Make _merge_isolated_script_shards robust to harness failures.

Make _merge_isolated_script_shards robust to harness failures.

Occasionally the harness fails catastrophically and doesn't write any
output.

BUG=628713
Committed: https://chromium.googlesource.com/chromium/tools/build/+/41c3f867f5138ee0dd392e161222ebde963c5c35

[Ken Russell (switch to Gerrit), 2016-07-15 19:11:03]

kbr@chromium.org changed reviewers:
+ dpranke@chromium.org, vadimsh@chromium.org

[Ken Russell (switch to Gerrit), 2016-07-15 19:11:04]

dpranke or vadimsh: please review. Thanks.

ynovikov: FYI.

[nednguyen, 2016-07-15 19:13:27]

Description was changed from

==========
Make _merge_isolated_script_shards robust to harness failures.

Occasionally the harness fails catastrophically and doesn't write any
output.

BUG=628713
==========

to

==========
Make _merge_isolated_script_shards robust to harness failures.

Occasionally the harness fails catastrophically and doesn't write any
output.

BUG=628713
==========

[Vadim Sh., 2016-07-15 19:16:32]

lgtm with nits

https://codereview.chromium.org/2150993005/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/test_utils/test_api.py (right):

https://codereview.chromium.org/2150993005/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/test_utils/test_api.py:136:
jsonish_results['times'] = { t : 0.1 for t in tests_run }
nit: no spaces after { and before }: {t: 0.1 ....}

https://codereview.chromium.org/2150993005/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/test_utils/test_api.py:149: if not i in
empty_shards:
nit: if i not in empty_shards

[Dirk Pranke, 2016-07-15 19:19:46]

lgtm w/ vadimsh's feedback addressed.

[Ken Russell (switch to Gerrit), 2016-07-15 19:21:41]

https://codereview.chromium.org/2150993005/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/test_utils/test_api.py (right):

https://codereview.chromium.org/2150993005/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/test_utils/test_api.py:136:
jsonish_results['times'] = { t : 0.1 for t in tests_run }
On 2016/07/15 19:16:31, Vadim Sh. wrote:
> nit: no spaces after { and before }: {t: 0.1 ....}

Done.

https://codereview.chromium.org/2150993005/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/test_utils/test_api.py:149: if not i in
empty_shards:
On 2016/07/15 19:16:31, Vadim Sh. wrote:
> nit: if i not in empty_shards

Done.

[Ken Russell (switch to Gerrit), 2016-07-15 19:21:45]

The CQ bit was checked by kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-07-15 19:21:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/2150993005/#ps20001
(title: "Addressed review feedback from vadimsh.")

[commit-bot: I haz the power, 2016-07-15 19:21:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 19:26:37]

Description was changed from

==========
Make _merge_isolated_script_shards robust to harness failures.

Occasionally the harness fails catastrophically and doesn't write any
output.

BUG=628713
==========

to

==========
Make _merge_isolated_script_shards robust to harness failures.

Occasionally the harness fails catastrophically and doesn't write any
output.

BUG=628713

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/41c3f867f5138ee0dd39...
==========

[commit-bot: I haz the power, 2016-07-15 19:26:38]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/41c3f867f5138ee0dd39...