scripts/slave/recipes/chromium.expected/dynamic_swarmed_failed_isolated_script_test.json - Issue 2150993005: Make _merge_isolated_script_shards robust to harness failures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium.expected/dynamic_swarmed_failed_isolated_script_test.json

Issue 2150993005: Make _merge_isolated_script_shards robust to harness failures. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Addressed review feedback from vadimsh. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test_harness_failure_zero_retcode.json ('k') | scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_linux_gpu.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium.expected/dynamic_swarmed_failed_isolated_script_test.json

diff --git a/scripts/slave/recipes/chromium.expected/dynamic_swarmed_failed_isolated_script_test.json b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_failed_isolated_script_test.json

index 43a1b652f2439cf8f36bed78a6ff8dde922058ed..600b8cd50305d4920b81b9d696ce811c293588d7 100644

--- a/scripts/slave/recipes/chromium.expected/dynamic_swarmed_failed_isolated_script_test.json

+++ b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_failed_isolated_script_test.json

@@ -419,7 +419,7 @@

"step returned non-zero exit code: 255",

"@@@STEP_TEXT@<br/>failures:<br/>test1.Test1<br/>test2.Test2<br/>@@@",

"@@@STEP_LOG_LINE@outdir_json@{@@@",

- "@@@STEP_LOG_LINE@outdir_json@ \"0/output.json\": \"{\\\"successes\\\": [], \\\"failures\\\": [\\\"test1.Test1\\\", \\\"test2.Test2\\\"], \\\"valid\\\": true}\", @@@",

+ "@@@STEP_LOG_LINE@outdir_json@ \"0/output.json\": \"{\\\"successes\\\": [], \\\"failures\\\": [\\\"test1.Test1\\\", \\\"test2.Test2\\\"], \\\"valid\\\": true, \\\"times\\\": {\\\"test2.Test2\\\": 0.1, \\\"test1.Test1\\\": 0.1}}\", @@@",

"@@@STEP_LOG_LINE@outdir_json@ \"summary.json\": \"{\\\"shards\\\": [{\\\"internal_failure\\\": false, \\\"failure\\\": false}]}\"@@@",

"@@@STEP_LOG_LINE@outdir_json@}@@@",

"@@@STEP_LOG_END@outdir_json@@@",