scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_harness_failure.json - Issue 2150993005: Make _merge_isolated_script_shards robust to harness failures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_harness_failure.json

Issue 2150993005: Make _merge_isolated_script_shards robust to harness failures. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Addressed review feedback from vadimsh. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_failed_isolated_script_test.json ('k') | scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_missing_shard.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_harness_failure.json

diff --git a/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_missing_shard.json b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_harness_failure.json

similarity index 98%

copy from scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_missing_shard.json

copy to scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_harness_failure.json

index cf9450164585f1070af33ed901d5fd6a6466f351..af377b124c470364b04c030a705152a964933861 100644

--- a/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_missing_shard.json

+++ b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_harness_failure.json

@@ -425,11 +425,12 @@

"~followup_annotations": [

"step returned non-zero exit code: 1",

"@@@STEP_LOG_LINE@outdir_json@{@@@",

- "@@@STEP_LOG_LINE@outdir_json@ \"0/output.json\": \"{\\\"successes\\\": [\\\"test1.Test1\\\", \\\"test2.Test2\\\"], \\\"failures\\\": [], \\\"valid\\\": true}\", @@@",

+ "@@@STEP_LOG_LINE@outdir_json@ \"0/output.json\": \"{\\\"successes\\\": [\\\"test1.Test1\\\", \\\"test2.Test2\\\"], \\\"failures\\\": [], \\\"valid\\\": true, \\\"times\\\": {\\\"test2.Test2\\\": 0.1, \\\"test1.Test1\\\": 0.1}}\", @@@",

+ "@@@STEP_LOG_LINE@outdir_json@ \"1/output.json\": \"\", @@@",

"@@@STEP_LOG_LINE@outdir_json@ \"summary.json\": \"{\\\"shards\\\": [{\\\"internal_failure\\\": false, \\\"failure\\\": false}, {\\\"internal_failure\\\": false, \\\"failure\\\": false}]}\"@@@",

"@@@STEP_LOG_LINE@outdir_json@}@@@",

"@@@STEP_LOG_END@outdir_json@@@",

- "@@@STEP_LOG_LINE@no_results_exc@no results from shard #1@@@",

+ "@@@STEP_LOG_LINE@no_results_exc@error decoding JSON results from shard #1@@@",

"@@@STEP_LOG_END@no_results_exc@@@",

"@@@STEP_LOG_LINE@invalid_results_exc@'failures'@@@",

"@@@STEP_LOG_END@invalid_results_exc@@@",