scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test_harness_failure_zero_retcode.json - Issue 2150993005: Make _merge_isolated_script_shards robust to harness failures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test_harness_failure_zero_retcode.json

Issue 2150993005: Make _merge_isolated_script_shards robust to harness failures. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Addressed review feedback from vadimsh. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.py ('k') | scripts/slave/recipes/chromium.expected/dynamic_swarmed_failed_isolated_script_test.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test_harness_failure_zero_retcode.json

diff --git a/scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test_harness_failure_zero_retcode.json b/scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test_harness_failure_zero_retcode.json

index 96486f483f613ca2ff71840808822fc30cd1820e..0b293970ba18ba5209ba6bde39c041f460153645 100644

--- a/scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test_harness_failure_zero_retcode.json

+++ b/scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test_harness_failure_zero_retcode.json

@@ -336,6 +336,10 @@

"@@@STEP_LOG_LINE@json.output@ \"test2.Test2\"@@@",

"@@@STEP_LOG_LINE@json.output@ ], @@@",

"@@@STEP_LOG_LINE@json.output@ \"successes\": [], @@@",

+ "@@@STEP_LOG_LINE@json.output@ \"times\": {@@@",

+ "@@@STEP_LOG_LINE@json.output@ \"test1.Test1\": 0.1, @@@",

+ "@@@STEP_LOG_LINE@json.output@ \"test2.Test2\": 0.1@@@",

+ "@@@STEP_LOG_LINE@json.output@ }, @@@",

"@@@STEP_LOG_LINE@json.output@ \"valid\": false@@@",

"@@@STEP_LOG_LINE@json.output@}@@@",

"@@@STEP_LOG_END@json.output@@@",