Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2150993002: Revert of Always apply UniformMatrix4fvStreamTextureMatrixCHROMIUM matrix argument. (Closed)

Created:
4 years, 5 months ago by wjmaclean
Modified:
4 years, 5 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin (slow to review), extensions-reviews_chromium.org, piman+watch_chromium.org, qsr+mojo_chromium.org, rjkroege, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Always apply UniformMatrix4fvStreamTextureMatrixCHROMIUM matrix argument. (patchset #11 id:220001 of https://codereview.chromium.org/1818073002/ ) Reason for revert: Broke the build on Mac GYP (dbg): https://build.chromium.org/p/chromium.mac/builders/Mac%20GYP%20(dbg) Original issue's description: > Always apply UniformMatrix4fvStreamTextureMatrixCHROMIUM matrix argument. > > Regardless of whether we have a stream texture matrix, we should apply > the transformation matrix held by the StreamTextureDrawQuad instance. > > Change the implementation of the extension to always premultiply either > the stream texture matrix or the identity matrix by the passed > transformation matrix. > > BUG=597681 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/5897d75b89294c388df2ec16b7519ecd635cc148 > Cr-Commit-Position: refs/heads/master@{#405507} TBR=enne@chromium.org,ccameron@chromium.org,liberato@chromium.org,sievers@chromium.org,tobiasjs@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=597681 Committed: https://crrev.com/a79d7c93a712da8b63e7ee78da2e4ce4302c1530 Cr-Commit-Position: refs/heads/master@{#405514}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -68 lines) Patch
M cc/layers/video_frame_provider_client_impl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M cc/layers/video_frame_provider_client_impl.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M cc/layers/video_layer_impl.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M cc/output/gl_renderer.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M cc/output/shader.cc View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/GLES2/extensions/CHROMIUM/CHROMIUM_stream_texture_matrix.txt View 2 chunks +8 lines, -8 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper_autogen.h View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_implementation_impl_autogen.h View 1 chunk +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_autogen.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_autogen.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_autogen.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_autogen.h View 1 chunk +6 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gl_stream_texture_image.h View 1 chunk +9 lines, -14 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 4 chunks +15 lines, -13 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 1 chunk +6 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers_autogen.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/ipc/service/stream_texture_android.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/gpu/avda_codec_image.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
wjmaclean
Created Revert of Always apply UniformMatrix4fvStreamTextureMatrixCHROMIUM matrix argument.
4 years, 5 months ago (2016-07-14 17:40:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2150993002/1
4 years, 5 months ago (2016-07-14 17:40:53 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 17:43:22 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 17:47:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a79d7c93a712da8b63e7ee78da2e4ce4302c1530
Cr-Commit-Position: refs/heads/master@{#405514}

Powered by Google App Engine
This is Rietveld 408576698